diff options
| author | Vadim B. Mikheev | 2001-02-06 06:24:00 +0000 |
|---|---|---|
| committer | Vadim B. Mikheev | 2001-02-06 06:24:00 +0000 |
| commit | 21d08bc1f606bbd840206b1846fa65fc9e1abab0 (patch) | |
| tree | b140c81b7f3cbb4ac770891c768605b3b23cbe9b | |
| parent | 3869b0885975fb1b804be2d690ab6ba7cb2f7607 (diff) | |
PageAddItem in overwrite mode: must *NOT* check itemid' flag if
OffsetNumber == MaxOffsetNumber + 1 - there may be garbage there!
| -rw-r--r-- | src/backend/storage/page/bufpage.c | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/src/backend/storage/page/bufpage.c b/src/backend/storage/page/bufpage.c index 02022f9333b..02528a30e67 100644 --- a/src/backend/storage/page/bufpage.c +++ b/src/backend/storage/page/bufpage.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/storage/page/bufpage.c,v 1.35 2001/01/24 19:43:08 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/storage/page/bufpage.c,v 1.36 2001/02/06 06:24:00 vadim Exp $ * *------------------------------------------------------------------------- */ @@ -112,12 +112,15 @@ PageAddItem(Page page, elog(NOTICE, "PageAddItem: tried overwrite after maxoff"); return InvalidOffsetNumber; } - itemId = &((PageHeader) page)->pd_linp[offsetNumber - 1]; - if (((*itemId).lp_flags & LP_USED) || - ((*itemId).lp_len != 0)) + if (offsetNumber < limit) { - elog(NOTICE, "PageAddItem: tried overwrite of used ItemId"); - return InvalidOffsetNumber; + itemId = &((PageHeader) page)->pd_linp[offsetNumber - 1]; + if (((*itemId).lp_flags & LP_USED) || + ((*itemId).lp_len != 0)) + { + elog(NOTICE, "PageAddItem: tried overwrite of used ItemId"); + return InvalidOffsetNumber; + } } } else |