summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBruce Momjian2007-01-25 14:52:23 +0000
committerBruce Momjian2007-01-25 14:52:23 +0000
commit0626a7d1b5364d0284ac622d9f7afc486838b729 (patch)
tree0026384fe8640c4854a8e73cde23458ce5223602
parent22bd156ff0b6727c1f5fb6069690f7e2a4cabcac (diff)
Reverse out use of Py_RETURN_TRUE in plpython, only supported in Python >=
2.3.
-rw-r--r--src/pl/plpython/plpython.c12
1 files changed, 9 insertions, 3 deletions
diff --git a/src/pl/plpython/plpython.c b/src/pl/plpython/plpython.c
index d5651c16f0c..f8d02f425be 100644
--- a/src/pl/plpython/plpython.c
+++ b/src/pl/plpython/plpython.c
@@ -1,7 +1,7 @@
/**********************************************************************
* plpython.c - python as a procedural language for PostgreSQL
*
- * $PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.91 2007/01/25 04:08:51 momjian Exp $
+ * $PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.92 2007/01/25 14:52:23 momjian Exp $
*
*********************************************************************
*/
@@ -1579,9 +1579,15 @@ PLy_typeinfo_dealloc(PLyTypeInfo * arg)
static PyObject *
PLyBool_FromString(const char *src)
{
+ /*
+ * We would like to use Py_RETURN_TRUE and Py_RETURN_FALSE here for
+ * generating SQL from trigger functions, but those are only
+ * supported in Python >= 2.3, and we support older
+ * versions. http://docs.python.org/api/boolObjects.html
+ */
if (src[0] == 't')
- Py_RETURN_TRUE;
- Py_RETURN_FALSE;
+ return PyInt_FromLong(1);
+ return PyInt_FromLong(0);
}
static PyObject *