summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2006-07-06WIN32 fixes:Bruce Momjian
I take out patch for this as a promise. This is client-build support of MS-VC6+. Fix for different getaddrinfo structure ordering on Win32 for IPv6. Hiroshi Saito
2006-07-06Backpatch dbmirror fix for escape handling.Bruce Momjian
> Upstream confirmed my reply in the last mail in [1]: the complete > escaping logic in DBMirror.pl is seriously screwew. > > [1] http://archives.postgresql.org/pgsql-bugs/2006-06/msg00065.php I finally found some time to debug this, and I think I found a better patch than the one you proposed. Mine is still hackish and is still a workaround around a proper quoting solution, but at least it repairs the parsing without introducing the \' quoting again. I consider this a band-aid patch to fix the recent security update. PostgreSQL gurus, would you consider applying this until a better solution is found for DBMirror.pl? Olivier, can you please confirm that the patch works for you, too? Backpatched to 8.0.X. Martin Pitt
2006-07-06Attached patch is required ot build with the CRT that comes with VisualBruce Momjian
Studio 2005. Basically MS defined errcode in the headers with a typedef, so we have to #define it out of the way. While at it, fix a function declaration in plpython that didn't match the implementation (volatile missing). Magnus Hagander
2006-07-06Please find attached two patches for documentation and regression testsBruce Momjian
for the usage of full time zone names. Joachim Wieland
2006-07-05Fixed remaining Coverity bugs.Michael Meskes
2006-07-04Documentation fixes for FILLFACTOR patch. Minor other editorialization.Tom Lane
2006-07-04Modify:Bruce Momjian
< o -Add PQescapeIdentifier() > o Add PQescapeIdentifierConn()
2006-07-04Remove libpq's PQescapeIdentifier(), not safe from injection attacks.Bruce Momjian
2006-07-04Fix typos in comments.Neil Conway
2006-07-03Code review for FILLFACTOR patch. Change WITH grammar as per earlierTom Lane
discussion (including making def_arg allow reserved words), add missed opt_definition for UNIQUE case. Put the reloptions support code in a less random place (I chose to make a new file access/common/reloptions.c). Eliminate header inclusion creep. Make the index options functions safely user-callable (seems like client apps might like to be able to test validity of options before trying to make an index). Reduce overhead for normal case with no options by allowing rd_options to be NULL. Fix some unmaintainably klugy code, including getting rid of Natts_pg_class_fixed at long last. Some stylistic cleanup too, and pay attention to keeping comments in sync with code. Documentation still needs work, though I did fix the omissions in catalogs.sgml and indexam.sgml.
2006-07-03Fix broken markup.Tom Lane
2006-07-02Do a pass of code review for the ALTER TABLE ADD INHERITS patch. KeepNeil Conway
the read lock we hold on the table's parent relation until commit. Update equalfuncs.c for the new field in AlterTableCmd. Various improvements to comments, variable names, and error reporting. There is room for further improvement here, but this is at least a step in the right direction.
2006-07-02Add FILLFACTOR to CREATE INDEX.Bruce Momjian
ITAGAKI Takahiro
2006-07-02Done:Bruce Momjian
> * -Add fillfactor to control reserved free space during index creation
2006-07-02Done:Bruce Momjian
< o Add ALTER TABLE tab ADD/DROP INHERITS parent < < This allows tables to be added/removed from an inheritance < hierarchy. This is particularly useful for table partitioning. < http://archives.postgresql.org/pgsql-hackers/2006-05/msg00988.php < > o -Add ALTER TABLE tab INHERIT / NO INHERIT parent
2006-07-02ALTER TABLE ... ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)Bruce Momjian
Open items: There were a few tangentially related issues that have come up that I think are TODOs. I'm likely to tackle one or two of these next so I'm interested in hearing feedback on them as well. . Constraints currently do not know anything about inheritance. Tom suggested adding a coninhcount and conislocal like attributes have to track their inheritance status. . Foreign key constraints currently do not get copied to new children (and therefore my code doesn't verify them). I don't think it would be hard to add them and treat them like CHECK constraints. . No constraints at all are copied to tables defined with LIKE. That makes it hard to use LIKE to define new partitions. The standard defines LIKE and specifically says it does not copy constraints. But the standard already has an option called INCLUDING DEFAULTS; we could always define a non-standard extension LIKE table INCLUDING CONSTRAINTS that gives the user the option to request a copy including constraints. . Personally, I think the whole attislocal thing is bunk. The decision about whether to drop a column from children tables or not is something that should be up to the user and trying to DWIM based on whether there was ever a local definition or the column was acquired purely through inheritance is hardly ever going to match up with user expectations. . And of course there's the whole unique and primary key constraint issue. I think to get any traction at all on this you have a prerequisite of a real partitioned table implementation where the system knows what the partition key is so it can recognize when it's a leading part of an index key. Greg Stark
2006-07-01Fix oversight in planning for multiple indexscans driven byTom Lane
ScalarArrayOpExpr index quals: we were estimating the right total number of rows returned, but treating the index-access part of the cost as if a single scan were fetching that many consecutive index tuples. Actually we should treat it as a multiple indexscan, and if there are enough of 'em the Mackert-Lohman discount should kick in.
2006-07-01Revise the planner's handling of "pseudoconstant" WHERE clauses, that isTom Lane
clauses containing no variables and no volatile functions. Such a clause can be used as a one-time qual in a gating Result plan node, to suppress plan execution entirely when it is false. Even when the clause is true, putting it in a gating node wins by avoiding repeated evaluation of the clause. In previous PG releases, query_planner() would do this for pseudoconstant clauses appearing at the top level of the jointree, but there was no ability to generate a gating Result deeper in the plan tree. To fix it, get rid of the special case in query_planner(), and instead process pseudoconstant clauses through the normal RestrictInfo qual distribution mechanism. When a pseudoconstant clause is found attached to a path node in create_plan(), pull it out and generate a gating Result at that point. This requires special-casing pseudoconstants in selectivity estimation and cost_qual_eval, but on the whole it's pretty clean. It probably even makes the planner a bit faster than before for the normal case of no pseudoconstants, since removing pull_constant_clauses saves one useless traversal of the qual tree. Per gripe from Phil Frost.
2006-06-30Fix memory leak introduced in the prior commit, detected by Tom Lane.Alvaro Herrera
2006-06-30Fix use-after-free error reported by Neil Conway.Alvaro Herrera
2006-06-30Update item for GUID:Bruce Momjian
< * Add 128-bit Universally Unique Identifier (UUID) > * Add Globally/Universally Unique Identifier (GUID/UUID)
2006-06-29Remove the separate 'stats buffer' process, letting backend stats messagesTom Lane
be delivered directly to the collector process. The extra process context swaps required to transfer data through the buffer process seem to outweigh any value the buffering might have. Per recent discussion and tests. I modified Bruce's draft patch to use poll() rather than select() where available (this makes a noticeable difference on my system), and fixed up the EXEC_BACKEND case.
2006-06-29Change TRUNCATE's method for searching for foreign-key references so thatTom Lane
the order in which it visits tables is not dependent on the physical order of pg_constraint entries, and neither are the error messages it gives. This should correct recently-noticed instability in regression tests.
2006-06-29Change URL for SITC:Bruce Momjian
< http://momjian.us/cgi-bin/pgsitc > http://archives.postgresql.org/pgsql-hackers/2006-06/msg01534.php
2006-06-29Add:Bruce Momjian
> * Add 128-bit Universally Unique Identifier (UUID)
2006-06-28Add missing #include directive: pg_constraint.h declares some functionsNeil Conway
whose prototypes include the "List" type, so it ought to include the list header file.
2006-06-28Fix typo in comment.Neil Conway
2006-06-28Editorialization for the additions to the CREATE TABLE reference pageNeil Conway
made as part of the recent INCLUDING CONSTRAINTS patch. The text could stand further improvement, but this is at least a step in the right direction.
2006-06-28Add URL for SITCBruce Momjian
> http://momjian.us/cgi-bin/pgsitc
2006-06-28Improve planner estimates for size of tuple hash tables.Tom Lane
2006-06-28Fix hash aggregation to suppress unneeded columns from being stored inTom Lane
tuple hash table entries. This addresses the problem previously noted that use of a 'physical tlist' in the input scan node could bloat the hash table entries far beyond what the planner expects. It's a better answer than my previous thought of undoing the physical tlist optimization, because we can also remove columns that are needed to compute the aggregate functions but aren't part of the grouping column set.
2006-06-28Adjust TupleHashTables to use MinimalTuple format for contained tuples.Tom Lane
2006-06-28Update:Bruce Momjian
< o Add support for WITH HOLD cursors > o Add support for WITH HOLD and SCROLL cursors > > PL/pgSQL cursors should support the same syntax as > backend cursors. >
2006-06-28Update Russian FAQ.Bruce Momjian
Viktor Vislobokov
2006-06-28Forget to add new file :((Teodor Sigaev
2006-06-28ChangesTeodor Sigaev
* new split algorithm (as proposed in http://archives.postgresql.org/pgsql-hackers/2006-06/msg00254.php) * possible call pickSplit() for second and below columns * add spl_(l|r)datum_exists to GIST_SPLITVEC - pickSplit should check its values to use already defined spl_(l|r)datum for splitting. pickSplit should set spl_(l|r)datum_exists to 'false' (if they was 'true') to signal to caller about using spl_(l|r)datum. * support for old pickSplit(): not very optimal but correct split * remove 'bytes' field from GISTENTRY: in any case size of value is defined by it's type. * split GIST_SPLITVEC to two structures: one for using in picksplit and second - for internal use. * some code refactoring * support of subsplit to rtree opclasses TODO: add support of subsplit to contrib modules
2006-06-27Remove embedded newline in string literal --- seems to make newer gccTom Lane
versions very unhappy, and shouldn't be there anyway.
2006-06-27Add GUC update_process_title to control whether 'ps' display is updatedBruce Momjian
for every command, default to on.
2006-06-27Convert hash join code to use MinimalTuple format in tuple hash tableTom Lane
and batch files. Should reduce memory and I/O demands for such joins.
2006-06-27Default stats_command_string to 'on', now that its overhead is minimal.Bruce Momjian
2006-06-27Put #ifdef NOT_USED around posix_fadvise call. We may want to resurrectTom Lane
this someday, but right now it seems that posix_fadvise is immature to the point of being broken on many platforms ... and we don't have any benchmark evidence proving it's worth spending time on.
2006-06-27Revert patch, doesn't do what it should:Bruce Momjian
* %Disallow changing default expression of a SERIAL column Dhanaraj M
2006-06-27Extend the MinimalTuple concept to tuplesort.c, thereby reducing theTom Lane
per-tuple space overhead for sorts in memory. I chose to replace the previous patch that tried to write out the bare minimum amount of data when sorting on disk; instead, just dump the MinimalTuples as-is. This wastes 3 to 10 bytes per tuple depending on architecture and null-bitmap length, but the simplification in the writetup/readtup routines seems worth it.
2006-06-27Will revert in next patch more cleanly.Bruce Momjian
> * -Disallow changing DEFAULT expression of a SERIAL column
2006-06-27Not done:Bruce Momjian
< * -Disallow changing DEFAULT expression of a SERIAL column > * %Disallow changing DEFAULT expression of a SERIAL column
2006-06-27Clamp last_anl_tuples to n_live_tuples, in case we vacuum a table withoutAlvaro Herrera
analyzing, so that future analyze threshold calculations don't get confused. Also, make sure we correctly track the decrease of live tuples cause by deletes. Per report from Dylan Hansen, patches by Tom Lane and me.
2006-06-27Add INCLUDING CONSTRAINTS to CREATE TABLE LIKE.Bruce Momjian
Greg Stark
2006-06-27Done:Bruce Momjian
< * %Disallow changing DEFAULT expression of a SERIAL column? < < This should be done only if the existing SERIAL problems cannot be < fixed. < > * -Disallow changing DEFAULT expression of a SERIAL column
2006-06-27Disallow changing/dropping default expression of a SERIAL columnBruce Momjian
Dhanaraj M
2006-06-27Fix for recent Win32 pg_dump tar temp file patch.Bruce Momjian
Hiroshi Saito