summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2010-07-06Update pgindent testing instructions.Bruce Momjian
2010-07-06Still more third thoughts: when linking shared libraries, LDFLAGS probablyTom Lane
needs to appear before anything placed in SHLIB_LINK. This is because SHLIB_LINK is typically a subset of LIBS, and LIBS has to appear after LDFLAGS on platforms that are sensitive to the relative order of -L and -l switches.
2010-07-06Allow for LDFLAGS_SL already having a value in Makefile.aix.Tom Lane
Per buildfarm results.
2010-07-05Dept. of third thoughts: PG_LIBS may contain a -L switch, so it had betterTom Lane
stay in front of LDFLAGS.
2010-07-05Make sure LDFLAGS come before LIBS when linking contrib programs.Tom Lane
Solaris, at least, seems to be sensitive to the relative order of -L and -l switches, so this is needed. Per buildfarm results.
2010-07-05Fix a few single-file (MODULES, not MODULE_big) contrib makefiles that wereTom Lane
supposing that they should set SHLIB_LINK rather than LDFLAGS_SL. Since these don't go through Makefile.shlib that was a no-op on most platforms. Also regularize the few platform-specific Makefiles that did pay attention to SHLIB_LINK: it seems that the real value of that is to pull in BE_DLLLIBS, so do that instead. Per buildfarm failures on cygwin.
2010-07-05Split the LDFLAGS make variable into two parts: LDFLAGS is now used forTom Lane
linking both executables and shared libraries, and we add on LDFLAGS_EX when linking executables or LDFLAGS_SL when linking shared libraries. This provides a significantly cleaner way of dealing with link-time switches than the former behavior. Also, make sure that the various platform-specific %.so: %.o rules incorporate LDFLAGS and LDFLAGS_SL; most of them missed that before. (I did not add these variables for the platforms that invoke $(LD) directly, however. It's not clear if we can do that safely, since for the most part we assume these variables use CC command-line syntax.) Per gripe from Aaron Swenson and subsequent investigation.
2010-07-05The previous fix in CVS HEAD and 8.4 for handling the case where a cursorHeikki Linnakangas
being used in a PL/pgSQL FOR loop is closed was inadequate, as Tom Lane pointed out. The bug affects FOR statement variants too, because you can close an implicitly created cursor too by guessing the "<unnamed portal X>" name created for it. To fix that, "pin" the portal to prevent it from being dropped while it's being used in a PL/pgSQL FOR loop. Backpatch all the way to 7.4 which is the oldest supported version.
2010-07-04Simplify test_fsync duration computation.Bruce Momjian
2010-07-04Report test_fynsc times in tests per second, instead of total seconds.Bruce Momjian
2010-07-03Remove SGML tab.Bruce Momjian
2010-07-03Don't set recoveryLastXTime when replaying a checkpoint --- that was a bogusTom Lane
idea from the start since the variable is only meant to track commit/abort events. This patch reverts the logic around the variable to what it was in 8.4, except that the value is now kept in shared memory rather than a static variable, so that it can be reported correctly by CreateRestartPoint (which is executed in the bgwriter).
2010-07-03Make vacuum_defer_cleanup_age be PGC_SIGHUP level, since it's not sensibleTom Lane
to have different values in different processes of the primary server. Also put it into the "Streaming Replication" GUC category; it doesn't belong in "Standby Servers" because you use it on the master not the standby. In passing also correct guc.c's idea of wal_keep_segments' category.
2010-07-03Replace max_standby_delay with two parameters, max_standby_archive_delay andTom Lane
max_standby_streaming_delay, and revise the implementation to avoid assuming that timestamps found in WAL records can meaningfully be compared to clock time on the standby server. Instead, the delay limits are compared to the elapsed time since we last obtained a new WAL segment from archive or since we were last "caught up" to WAL data arriving via streaming replication. This avoids problems with clock skew between primary and standby, as well as other corner cases that the original coding would misbehave in, such as the primary server having significant idle time between transactions. Per my complaint some time ago and considerable ensuing discussion. Do some desultory editing on the hot standby documentation, too.
2010-07-03Document more clearly on XML namespaces inside xpath functionBruce Momjian
Nikolay Samokhvalov
2010-07-03Make pg_upgrade copyrights just 2010, not 2010-2010.Bruce Momjian
2010-07-03Add copyrights to pg_upgrade and pg_upgrade_tools files, per Tom.Bruce Momjian
2010-07-03Add CVS tags to pg_upgrade and pg_upgrade_support files, per requestBruce Momjian
from Tom.
2010-07-03Allow REASSIGNED OWNED to handle opclasses and opfamilies.Robert Haas
Backpatch to 8.3, which is as far back as we have opfamilies. The opclass portion could probably be backpatched to 8.2, when REASSIGN OWNED was added, but for now I have not done that. Asko Tiidumaa, with minor adjustments by me.
2010-07-03Fix assorted misstatements and poor wording in the descriptions of the I/OTom Lane
formats for geometric types. Per bug #5536 from Jon Strait, and my own testing. Back-patch to all supported branches, since this doco has been wrong right along -- we certainly haven't changed the I/O behavior of these types in many years.
2010-07-03Additional cross-references to window functions documentation.Robert Haas
Erik Rijkers
2010-07-02Unbreak MSVC builds by removing copydir.c from list of libpgport filesAndrew Dunstan
2010-07-02Remove hstore % text[] operator; use slice() function instead.Robert Haas
David Wheeler, with one small correction by me.
2010-07-02Move copydir.c from src/port to src/backend/storage/fileRobert Haas
The previous commit to make copydir() interruptible prevented postgres.exe from linking on MinGW and Cygwin, because on those platforms libpgport_srv.a can't freely reference symbols defined by the backend. Since that code is already backend-specific anyway, just move the whole file into the backend rather than adding further kludges to deal with the symbols needed by CHECK_FOR_INTERRUPTS(). This probably needs some further cleanup, but this commit just moves the file as-is, which should hopefully be enough to turn the buildfarm green again.
2010-07-02Issue 'mkdir' hint when replying CREATE TABLESPACE in recovery mode.Bruce Momjian
Per idea from Fujii Masao
2010-07-01Allow copydir() to be interrupted.Robert Haas
This makes ALTER DATABASE .. SET TABLESPACE and CREATE DATABASE more sensitive to interrupts. Backpatch to 8.4, where ALTER DATABASE .. SET TABLESPACE was introduced. We could go back further, but in the absence of complaints about the CREATE DATABASE case it doesn't seem worth it. Guillaume Lelarge, with a small correction by me.
2010-07-01Get rid of some more stuff that duplicates c.h or port.h.Tom Lane
2010-07-01Remove port.h prototypes from pg_upgrade.h, per report from Robert Haas.Bruce Momjian
2010-07-01Allow ALTER TABLE .. SET TABLESPACE to be interrupted.Robert Haas
Backpatch to 8.0, where tablespaces were introduced. Guillaume Lelarge
2010-07-01Update 9.0 release notes so streaming replication and hot standby is notBruce Momjian
assumed to require continuous archiving. Per report from Fujii Masao
2010-06-30stringToNode() and deparse_expression_pretty() crash on invalid input,Heikki Linnakangas
but we have nevertheless exposed them to users via pg_get_expr(). It would be too much maintenance effort to rigorously check the input, so put a hack in place instead to restrict pg_get_expr() so that the argument must come from one of the system catalog columns known to contain valid expressions. Per report from Rushabh Lathia. Backpatch to 7.4 which is the oldest supported version at the moment.
2010-06-30Correct missing/misspelled surname.Andrew Dunstan
2010-06-30Document that /bin/true on Windows is implemented by 'REM'.Bruce Momjian
2010-06-29In documentation, use "lower case"/"upper case" consistently (use spaceBruce Momjian
between words).
2010-06-29Document that shared_preload_libraries and local_preload_librariesBruce Momjian
lowercase the library names, unless double-quoted.
2010-06-29Add compatibility note warning that plpgsql is now stricter about the columnTom Lane
datatypes of composite results, per gripe from Marcel Asio. Some desultory copy-editing of plpgsql-related sections of the release notes.
2010-06-29Add C comment about why synchronous_commit=off behavior can loseBruce Momjian
committed transactions in a postmaster crash.
2010-06-29Message tuningPeter Eisentraut
2010-06-29Use different function names for plpython3 handlers, to avoid clashes inPeter Eisentraut
pg_pltemplate This should have a catversion bump, but it's still being debated whether it's worth it during beta.
2010-06-29Add note clarifying that XML fragments don't accept DTDsPeter Eisentraut
per complaint from Craig Ringer
2010-06-28Fix doc double-wording in non-durable patch.Bruce Momjian
Report from Thom Brown
2010-06-28Add new Non-Durable Settings documentation section.Bruce Momjian
Document that synchronous_commit can lose transactions in a db crash, not just a OS crash.
2010-06-28emode_for_corrupt_record shouldn't reduce LOG messages to WARNING.Robert Haas
In non-interactive sessions, WARNING sorts below LOG.
2010-06-28Add guidelines for formatting errcontext stringsPeter Eisentraut
2010-06-28Remove tab from SGML.Bruce Momjian
2010-06-28Improve pg_dump's checkSeek() function to verify the functioning of ftelloTom Lane
as well as fseeko, and to not assume that fseeko(fp, 0, SEEK_CUR) proves anything. Also improve some related comments. Per my observation that the SEEK_CUR test didn't actually work on some platforms, and subsequent discussion with Robert Haas. Back-patch to 8.4. In earlier releases it's not that important whether we get the hasSeek test right, but with parallel restore it matters.
2010-06-27Fix pg_restore so parallel restore doesn't fail when the input file doesn'tTom Lane
contain data offsets (which it won't, if pg_dump thought its output wasn't seekable). To do that, remove an unnecessarily aggressive error check, and instead fail if we get to the end of the archive without finding the desired data item. Also improve the error message to be more specific about the cause of the problem. Per discussion of recent report from Igor Neyman. Back-patch to 8.4 where parallel restore was introduced.
2010-06-25Rewrite docs for new libpq keepalive parameters.Robert Haas
The revised documentation makes it more clear that these are client-side parameters, rather than server side parameters. It also puts the main point of each parameter first, and consolidates the conditions under which it might be ignored in a single list at the end.
2010-06-25Make AIX suggestions about disabling ipv6 more version-sensitive.Robert Haas
Chris Browne, based on a report from John Pierce.
2010-06-25Fix thinko in tok_is_keyword(): it was looking at the wrong union variantTom Lane
of YYSTYPE, and hence returning the wrong answer for cases where a plpgsql "unreserved keyword" really does conflict with a variable name. Obviously I didn't test this enough :-(. Per bug #5524 from Peter Gagarinov.