summaryrefslogtreecommitdiff
path: root/src/pl/plpgsql
diff options
context:
space:
mode:
authorPeter Eisentraut2022-07-13 09:40:00 +0000
committerPeter Eisentraut2022-07-13 09:43:40 +0000
commit503e3833ef240c94e114be8703046d52f24da021 (patch)
tree5a8ef2aded96066ae2beb0409c0147d30ba1b038 /src/pl/plpgsql
parent7057bf23546868ee5f1d9721e7129fb636aab042 (diff)
Remove useless assertions
We don't need Assert(IsA(foo, String)) right before running strVal(foo), since strVal() already does the assertion internally (via castNode()).
Diffstat (limited to 'src/pl/plpgsql')
-rw-r--r--src/pl/plpgsql/src/pl_comp.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/src/pl/plpgsql/src/pl_comp.c b/src/pl/plpgsql/src/pl_comp.c
index b791c23f06..61fbdf0686 100644
--- a/src/pl/plpgsql/src/pl_comp.c
+++ b/src/pl/plpgsql/src/pl_comp.c
@@ -1213,7 +1213,6 @@ resolve_column_ref(ParseState *pstate, PLpgSQL_expr *expr,
{
Node *field1 = (Node *) linitial(cref->fields);
- Assert(IsA(field1, String));
name1 = strVal(field1);
nnames_scalar = 1;
nnames_wholerow = 1;
@@ -1224,7 +1223,6 @@ resolve_column_ref(ParseState *pstate, PLpgSQL_expr *expr,
Node *field1 = (Node *) linitial(cref->fields);
Node *field2 = (Node *) lsecond(cref->fields);
- Assert(IsA(field1, String));
name1 = strVal(field1);
/* Whole-row reference? */
@@ -1236,7 +1234,6 @@ resolve_column_ref(ParseState *pstate, PLpgSQL_expr *expr,
break;
}
- Assert(IsA(field2, String));
name2 = strVal(field2);
colname = name2;
nnames_scalar = 2;
@@ -1250,9 +1247,7 @@ resolve_column_ref(ParseState *pstate, PLpgSQL_expr *expr,
Node *field2 = (Node *) lsecond(cref->fields);
Node *field3 = (Node *) lthird(cref->fields);
- Assert(IsA(field1, String));
name1 = strVal(field1);
- Assert(IsA(field2, String));
name2 = strVal(field2);
/* Whole-row reference? */
@@ -1264,7 +1259,6 @@ resolve_column_ref(ParseState *pstate, PLpgSQL_expr *expr,
break;
}
- Assert(IsA(field3, String));
name3 = strVal(field3);
colname = name3;
nnames_field = 2;