diff options
| author | Peter Geoghegan | 2023-04-10 18:15:41 +0000 |
|---|---|---|
| committer | Peter Geoghegan | 2023-04-10 18:15:41 +0000 |
| commit | 5d6728e588c37a4e458db9d55b308c8a3832a944 (patch) | |
| tree | 1d69811d81d7013947d1bbcef401cb98c205182e /src/include/access | |
| parent | fbbd7edca867ea8f8bd7540492e527fdb16d954b (diff) | |
Fix nbtree posting list update desc output.
We cannot use the generic array_desc approach with per-tuple nbtree
posting list update metadata because array_desc can only deal with fixed
width elements (e.g., page offset numbers). Using array_desc led to
incorrect rmgr descriptions for updates from nbtree DELETE/VACUUM WAL
records.
To fix, add specialized code to describe the update metadata as array
elements in desc output. We now iterate over the update metadata using
an approach that matches related REDO routines.
Also stop showing the updates offset number array separately in nbtree
DELETE/VACUUM desc output. It's redundant information, since the same
page offset numbers appear in the description of each individual update
element. Also make some small tweaks to the way that we format arrays
in all desc routines (not just nbtree desc routines) to make arrays a
little less verbose.
Oversight in commit 1c453cfd, which enhanced the nbtree rmgr desc
routines.
Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-WzkbYuvwYKm-Y-72QEh6SPMQcAo9uONv+mR3bMGcu9E_Cg@mail.gmail.com
Diffstat (limited to 'src/include/access')
| -rw-r--r-- | src/include/access/rmgrdesc_utils.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/include/access/rmgrdesc_utils.h b/src/include/access/rmgrdesc_utils.h index 13552d6f35..00e6146490 100644 --- a/src/include/access/rmgrdesc_utils.h +++ b/src/include/access/rmgrdesc_utils.h @@ -17,7 +17,6 @@ extern void array_desc(StringInfo buf, void *array, size_t elem_size, int count, void *data); extern void offset_elem_desc(StringInfo buf, void *offset, void *data); extern void redirect_elem_desc(StringInfo buf, void *offset, void *data); -extern void relid_desc(StringInfo buf, void *relid, void *data); -extern void uint16_elem_desc(StringInfo buf, void *value, void *data); +extern void oid_elem_desc(StringInfo buf, void *relid, void *data); #endif /* RMGRDESC_UTILS_H */ |