diff options
| author | Peter Eisentraut | 2014-04-18 04:03:19 +0000 |
|---|---|---|
| committer | Peter Eisentraut | 2014-04-18 04:03:19 +0000 |
| commit | e7128e8dbb305059c30ec085461297e619bcbff4 (patch) | |
| tree | ed4bf968847b30a098d113bb787adc2b97c687e0 /contrib/fuzzystrmatch | |
| parent | 01563158235f5650743fd9b1dfa80c3d8faf89bb (diff) | |
Create function prototype as part of PG_FUNCTION_INFO_V1 macro
Because of gcc -Wmissing-prototypes, all functions in dynamically
loadable modules must have a separate prototype declaration. This is
meant to detect global functions that are not declared in header files,
but in cases where the function is called via dfmgr, this is redundant.
Besides filling up space with boilerplate, this is a frequent source of
compiler warnings in extension modules.
We can fix that by creating the function prototype as part of the
PG_FUNCTION_INFO_V1 macro, which such modules have to use anyway. That
makes the code of modules cleaner, because there is one less place where
the entry points have to be listed, and creates an additional check that
functions have the right prototype.
Remove now redundant prototypes from contrib and other modules.
Diffstat (limited to 'contrib/fuzzystrmatch')
| -rw-r--r-- | contrib/fuzzystrmatch/dmetaphone.c | 3 | ||||
| -rw-r--r-- | contrib/fuzzystrmatch/fuzzystrmatch.c | 12 |
2 files changed, 0 insertions, 15 deletions
diff --git a/contrib/fuzzystrmatch/dmetaphone.c b/contrib/fuzzystrmatch/dmetaphone.c index 19413b481a..5001288bb6 100644 --- a/contrib/fuzzystrmatch/dmetaphone.c +++ b/contrib/fuzzystrmatch/dmetaphone.c @@ -114,9 +114,6 @@ The remaining code is authored by Andrew Dunstan <amdunstan@ncshp.org> and #include <stdarg.h> #include <assert.h> -extern Datum dmetaphone(PG_FUNCTION_ARGS); -extern Datum dmetaphone_alt(PG_FUNCTION_ARGS); - /* prototype for the main function we got from the perl module */ static void DoubleMetaphone(char *, char **); diff --git a/contrib/fuzzystrmatch/fuzzystrmatch.c b/contrib/fuzzystrmatch/fuzzystrmatch.c index 218eced921..7a53d8a008 100644 --- a/contrib/fuzzystrmatch/fuzzystrmatch.c +++ b/contrib/fuzzystrmatch/fuzzystrmatch.c @@ -45,18 +45,6 @@ PG_MODULE_MAGIC; - -/* - * External declarations for exported functions - */ -extern Datum levenshtein_with_costs(PG_FUNCTION_ARGS); -extern Datum levenshtein(PG_FUNCTION_ARGS); -extern Datum levenshtein_less_equal_with_costs(PG_FUNCTION_ARGS); -extern Datum levenshtein_less_equal(PG_FUNCTION_ARGS); -extern Datum metaphone(PG_FUNCTION_ARGS); -extern Datum soundex(PG_FUNCTION_ARGS); -extern Datum difference(PG_FUNCTION_ARGS); - /* * Soundex */ |