diff options
| author | Tom Lane | 2018-08-12 22:46:01 +0000 |
|---|---|---|
| committer | Tom Lane | 2018-08-12 22:46:01 +0000 |
| commit | 46b5e7c4b5befbf6ac86d827a3a58f1f02c7338e (patch) | |
| tree | d650f4d3293ec1d27961b17baa7cb5a020a973d7 /configure | |
| parent | d11eae09e48694ad6b4139bbb7d7b112833301f5 (diff) | |
Revert "Distinguish printf-like functions that support %m from those that don't."
This reverts commit 3a60c8ff892a8242b907f44702bfd9f1ff877d45. Buildfarm
results show that that caused a whole bunch of new warnings on platforms
where gcc believes the local printf to be non-POSIX-compliant. This
problem outweighs the hypothetical-anyway possibility of getting warnings
for misuse of %m. We could use gnu_printf archetype when we've substituted
src/port/snprintf.c, but that brings us right back to the problem of not
getting warnings for %m.
A possible answer is to attack it in the other direction by insisting
that %m support be included in printf's feature set, but that will take
more investigation. In the meantime, revert the previous change, and
update the comment for PGAC_C_PRINTF_ARCHETYPE to more fully explain
what's going on.
Discussion: https://postgr.es/m/2975.1526862605@sss.pgh.pa.us
Diffstat (limited to 'configure')
| -rwxr-xr-x | configure | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -13362,8 +13362,8 @@ _ACEOF ;; esac -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for printf format archetype for %m" >&5 -$as_echo_n "checking for printf format archetype for %m... " >&6; } +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for printf format archetype" >&5 +$as_echo_n "checking for printf format archetype... " >&6; } if ${pgac_cv_printf_archetype+:} false; then : $as_echo_n "(cached) " >&6 else @@ -13394,7 +13394,7 @@ fi $as_echo "$pgac_cv_printf_archetype" >&6; } cat >>confdefs.h <<_ACEOF -#define PG_PRINTF_ATTRIBUTE_M $pgac_cv_printf_archetype +#define PG_PRINTF_ATTRIBUTE $pgac_cv_printf_archetype _ACEOF |