From 75456a03cee1c0caed37371843273eee4dc73bba Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Tue, 26 Jun 2012 09:32:38 +0900 Subject: Remove useless argument in function DataNodeCopyBegin of execRemote.c This function was referencing to a boolean flag as a COPY TO/FROM switch but is not used by code. --- src/backend/commands/copy.c | 5 ++--- src/backend/pgxc/pool/execRemote.c | 2 +- src/include/pgxc/execRemote.h | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c index 9b48ba2ce7..f47b971783 100644 --- a/src/backend/commands/copy.c +++ b/src/backend/commands/copy.c @@ -1506,9 +1506,8 @@ BeginCopy(bool is_from, if (cstate->rel_loc) { cstate->connections = DataNodeCopyBegin(cstate->query_buf.data, - exec_nodes->nodeList, - GetActiveSnapshot(), - is_from); + exec_nodes->nodeList, + GetActiveSnapshot()); if (!cstate->connections) ereport(ERROR, (errcode(ERRCODE_CONNECTION_EXCEPTION), diff --git a/src/backend/pgxc/pool/execRemote.c b/src/backend/pgxc/pool/execRemote.c index 961b7bfd71..a34047b7e4 100644 --- a/src/backend/pgxc/pool/execRemote.c +++ b/src/backend/pgxc/pool/execRemote.c @@ -2058,7 +2058,7 @@ pgxc_node_remote_abort(void) * The copy_connections array must have room for NumDataNodes items */ PGXCNodeHandle** -DataNodeCopyBegin(const char *query, List *nodelist, Snapshot snapshot, bool is_from) +DataNodeCopyBegin(const char *query, List *nodelist, Snapshot snapshot) { int i; int conn_count = list_length(nodelist) == 0 ? NumDataNodes : list_length(nodelist); diff --git a/src/include/pgxc/execRemote.h b/src/include/pgxc/execRemote.h index 4992403c53..c99db99725 100644 --- a/src/include/pgxc/execRemote.h +++ b/src/include/pgxc/execRemote.h @@ -137,7 +137,7 @@ extern bool PGXCNodeRollbackPrepared(char *gid); extern void PGXCNodeCommitPrepared(char *gid); /* Copy command just involves Datanodes */ -extern PGXCNodeHandle** DataNodeCopyBegin(const char *query, List *nodelist, Snapshot snapshot, bool is_from); +extern PGXCNodeHandle** DataNodeCopyBegin(const char *query, List *nodelist, Snapshot snapshot); extern int DataNodeCopyIn(char *data_row, int len, ExecNodes *exec_nodes, PGXCNodeHandle** copy_connections); extern uint64 DataNodeCopyOut(ExecNodes *exec_nodes, PGXCNodeHandle** copy_connections, FILE* copy_file); extern void DataNodeCopyFinish(PGXCNodeHandle** copy_connections, int primary_dn_index, CombineType combine_type); -- cgit v1.2.3