diff options
| author | Heikki Linnakangas | 2017-05-08 08:26:07 +0000 |
|---|---|---|
| committer | Heikki Linnakangas | 2017-05-08 08:26:07 +0000 |
| commit | eb61136dc75a76caef8460fa939244d8593100f2 (patch) | |
| tree | abaac9eb3b4c093a6a4aabd40dfb0ec23f1bc84a /src/include | |
| parent | 1f30295eab65eddaa88528876ab66e7095f4bb65 (diff) | |
Remove support for password_encryption='off' / 'plain'.
Storing passwords in plaintext hasn't been a good idea for a very long
time, if ever. Now seems like a good time to finally forbid it, since we're
messing with this in PostgreSQL 10 anyway.
Remove the CREATE/ALTER USER UNENCRYPTED PASSSWORD 'foo' syntax, since
storing passwords unencrypted is no longer supported. ENCRYPTED PASSWORD
'foo' is still accepted, but ENCRYPTED is now just a noise-word, it does
the same as just PASSWORD 'foo'.
Likewise, remove the --unencrypted option from createuser, but accept
--encrypted as a no-op for backward compatibility. AFAICS, --encrypted was
a no-op even before this patch, because createuser encrypted the password
before sending it to the server even if --encrypted was not specified. It
added the ENCRYPTED keyword to the SQL command, but since the password was
already in encrypted form, it didn't make any difference. The documentation
was not clear on whether that was intended or not, but it's moot now.
Also, while password_encryption='on' is still accepted as an alias for
'md5', it is now marked as hidden, so that it is not listed as an accepted
value in error hints, for example. That's not directly related to removing
'plain', but it seems better this way.
Reviewed by Michael Paquier
Discussion: https://www.postgresql.org/message-id/16e9b768-fd78-0b12-cfc1-7b6b7f238fde@iki.fi
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/libpq/crypt.h | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/include/libpq/crypt.h b/src/include/libpq/crypt.h index 63724f39ee..9bad67c890 100644 --- a/src/include/libpq/crypt.h +++ b/src/include/libpq/crypt.h @@ -16,10 +16,13 @@ #include "datatype/timestamp.h" /* - * Types of password hashes or verifiers that can be stored in - * pg_authid.rolpassword. + * Types of password hashes or verifiers. * - * This is also used for the password_encryption GUC. + * Plaintext passwords can be passed in by the user, in a CREATE/ALTER USER + * command. They will be encrypted to MD5 or SCRAM-SHA-256 format, before + * storing on-disk, so only MD5 and SCRAM-SHA-256 passwords should appear + * in pg_authid.rolpassword. They are also the allowed values for the + * password_encryption GUC. */ typedef enum PasswordType { |