Get rid of long-since-vestigial Iter node type, in favor of adding a

returns-set boolean field in Func and Oper nodes.  This allows cleaner,
more reliable tests for expressions returning sets in the planner and
parser.  For example, a WHERE clause returning a set is now detected
and complained of in the parser, not only at runtime.

3 files changed, 46 insertions, 71 deletions

diff --git a/src/include/nodes/makefuncs.h b/src/include/nodes/makefuncs.h
index 4096c2d9fb..e3b6a16437 100644
--- a/src/include/nodes/makefuncs.h
+++ b/src/include/nodes/makefuncs.h
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $Id: makefuncs.h,v 1.35 2002/04/16 23:08:12 tgl Exp $
+ * $Id: makefuncs.h,v 1.36 2002/05/12 23:43:04 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -22,8 +22,9 @@ extern A_Expr *makeSimpleA_Expr(int oper, const char *name,
 								Node *lexpr, Node *rexpr);
 
 extern Oper *makeOper(Oid opno,
-		 Oid opid,
-		 Oid opresulttype);
+					  Oid opid,
+					  Oid opresulttype,
+					  bool opretset);
 
 extern Var *makeVar(Index varno,
 		AttrNumber varattno,
diff --git a/src/include/nodes/nodes.h b/src/include/nodes/nodes.h
index 492619e194..7de647d136 100644
--- a/src/include/nodes/nodes.h
+++ b/src/include/nodes/nodes.h
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $Id: nodes.h,v 1.106 2002/05/12 20:10:04 tgl Exp $
+ * $Id: nodes.h,v 1.107 2002/05/12 23:43:04 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -66,7 +66,6 @@ typedef enum NodeTag
 	T_Func,
 	T_FieldSelect,
 	T_ArrayRef,
-	T_Iter,
 	T_RelabelType,
 	T_RangeTblRef,
 	T_FromExpr,
diff --git a/src/include/nodes/primnodes.h b/src/include/nodes/primnodes.h
index 6eed89a704..342ac11bb5 100644
--- a/src/include/nodes/primnodes.h
+++ b/src/include/nodes/primnodes.h
@@ -10,7 +10,7 @@
  * Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $Id: primnodes.h,v 1.62 2002/05/12 20:10:05 tgl Exp $
+ * $Id: primnodes.h,v 1.63 2002/05/12 23:43:04 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -151,13 +151,52 @@ typedef struct Expr
 {
 	NodeTag		type;
 	Oid			typeOid;		/* oid of the type of this expression */
-	OpType		opType;			/* type of this expression */
+	OpType		opType;			/* kind of expression */
 	Node	   *oper;			/* operator node if needed (Oper, Func, or
 								 * SubPlan) */
 	List	   *args;			/* arguments to this expression */
 } Expr;
 
 /*
+ * Oper - Expr subnode for an OP_EXPR
+ *
+ * NOTE: in the good old days 'opno' used to be both (or either, or
+ * neither) the pg_operator oid, and/or the pg_proc oid depending
+ * on the postgres module in question (parser->pg_operator,
+ * executor->pg_proc, planner->both), the mood of the programmer,
+ * and the phase of the moon (rumors that it was also depending on the day
+ * of the week are probably false). To make things even more postgres-like
+ * (i.e. a mess) some comments were referring to 'opno' using the name
+ * 'opid'. Anyway, now we have two separate fields, and of course that
+ * immediately removes all bugs from the code...		[ sp :-) ].
+ *
+ * Note also that opid is not necessarily filled in immediately on creation
+ * of the node.  The planner makes sure it is valid before passing the node
+ * tree to the executor, but during parsing/planning opid is typically 0.
+ */
+typedef struct Oper
+{
+	NodeTag		type;
+	Oid			opno;			/* PG_OPERATOR OID of the operator */
+	Oid			opid;			/* PG_PROC OID of underlying function */
+	Oid			opresulttype;	/* PG_TYPE OID of result value */
+	bool		opretset;		/* true if operator returns set */
+	FunctionCachePtr op_fcache;	/* runtime state, else NULL */
+} Oper;
+
+/*
+ * Func - Expr subnode for a FUNC_EXPR
+ */
+typedef struct Func
+{
+	NodeTag		type;
+	Oid			funcid;			/* PG_PROC OID of the function */
+	Oid			funcresulttype;	/* PG_TYPE OID of result value */
+	bool		funcretset;		/* true if function returns set */
+	FunctionCachePtr func_fcache; /* runtime state, or NULL */
+} Func;
+
+/*
  * Var
  *
  * Note: during parsing/planning, varnoold/varoattno are always just copies
@@ -196,37 +235,6 @@ typedef struct Var
 	AttrNumber	varoattno;		/* original value of varattno */
 } Var;
 
-/*--------------------
- * Oper
- *
- * NOTE: in the good old days 'opno' used to be both (or either, or
- * neither) the pg_operator oid, and/or the pg_proc oid depending
- * on the postgres module in question (parser->pg_operator,
- * executor->pg_proc, planner->both), the mood of the programmer,
- * and the phase of the moon (rumors that it was also depending on the day
- * of the week are probably false). To make things even more postgres-like
- * (i.e. a mess) some comments were referring to 'opno' using the name
- * 'opid'. Anyway, now we have two separate fields, and of course that
- * immediately removes all bugs from the code...		[ sp :-) ].
- *
- * Note also that opid is not necessarily filled in immediately on creation
- * of the node.  The planner makes sure it is valid before passing the node
- * tree to the executor, but during parsing/planning opid is typically 0.
- *--------------------
- */
-typedef struct Oper
-{
-	NodeTag		type;
-	Oid			opno;			/* PG_OPERATOR OID of the operator */
-	Oid			opid;			/* PG_PROC OID for the operator's
-								 * underlying function */
-	Oid			opresulttype;
-	/* PG_TYPE OID of the operator's return value */
-	FunctionCachePtr op_fcache;
-	/* runtime state while running the function */
-} Oper;
-
-
 /*
  * Const
  */
@@ -283,39 +291,6 @@ typedef struct Param
 	Oid			paramtype;		/* PG_TYPE OID of the parameter's value */
 } Param;
 
-
-/*
- * Func
- */
-typedef struct Func
-{
-	NodeTag		type;
-	Oid			funcid;			/* PG_PROC OID of the function */
-	Oid			functype;		/* PG_TYPE OID of the function's return
-								 * value */
-	FunctionCachePtr func_fcache;
-
-	/*
-	 * runtime state while running this function. Where we are in the
-	 * execution of the function if it returns more than one value, etc.
-	 * See utils/fcache.h
-	 */
-} Func;
-
-/* ----------------
- * Iter
- *		can anyone explain what this is for?  Seems to have something to do
- *		with evaluation of functions that return sets...
- * ----------------
- */
-typedef struct Iter
-{
-	NodeTag		type;
-	Node	   *iterexpr;
-	Oid			itertype;		/* type of the iter expr (use for type
-								 * checking) */
-} Iter;
-
 /*
  * Aggref
  */