diff options
| author | Bruce Momjian | 1998-03-30 16:47:35 +0000 |
|---|---|---|
| committer | Bruce Momjian | 1998-03-30 16:47:35 +0000 |
| commit | 9a0dd4fb183958f59f68d8a5f096dd8df18d9b59 (patch) | |
| tree | 2843356dbd25f4e11cf4a414e56d6afae3775071 /src/bin | |
| parent | c579ce0fb03aaf92d184adf369cf13be013adf1b (diff) | |
There's a patch attached to fix gcc 2.8.x warnings, except for the
yyerror ones from bison. It also includes a few 'enhancements' to
the C programming style (which are, of course, personal).
The other patch removes the compilation of backend/lib/qsort.c, as
qsort() is a standard function in stdlib.h and can be used any
where else (and it is). It was only used in
backend/optimizer/geqo/geqo_pool.c, backend/optimizer/path/predmig.c,
and backend/storage/page/bufpage.c
> > Some or all of these changes might not be appropriate for v6.3,
since we > > are in beta testing and since they do not affect the
current functionality. > > For those cases, how about submitting
patches based on the final v6.3 > > release?
There's more to come. Please review these patches. I ran the
regression tests and they only failed where this was expected
(random, geo, etc).
Cheers,
Jeroen
Diffstat (limited to 'src/bin')
| -rw-r--r-- | src/bin/pg_dump/pg_dump.c | 6 | ||||
| -rw-r--r-- | src/bin/pg_version/pg_version.c | 4 |
2 files changed, 7 insertions, 3 deletions
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index f95d682964..85ac97b78f 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -21,7 +21,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.66 1998/03/16 05:41:39 momjian Exp $ + * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.67 1998/03/30 16:47:32 momjian Exp $ * * Modifications - 6/10/96 - dave@bensoft.com - version 1.13.dhb * @@ -1591,10 +1591,12 @@ getTables(int *numTables, FuncInfo *finfo, int numFuncs) findx++; } if (TRIGGER_FOR_UPDATE(tgtype)) + { if (findx > 0) strcat(query, " OR UPDATE"); else strcat(query, " UPDATE"); + } sprintf(query, "%s ON %s FOR EACH ROW EXECUTE PROCEDURE %s (", query, tblinfo[i].relname, tgfunc); for (findx = 0; findx < tgnargs; findx++) @@ -2508,6 +2510,7 @@ dumpTables(FILE *fout, TableInfo *tblinfo, int numTables, { ACLlist = ParseACL(tblinfo[i].relacl, &l); if (ACLlist == (ACL *) NULL) + { if (l == 0) continue; else @@ -2516,6 +2519,7 @@ dumpTables(FILE *fout, TableInfo *tblinfo, int numTables, tblinfo[i].relname); exit_nicely(g_conn); } + } /* Revoke Default permissions for PUBLIC */ fprintf(fout, diff --git a/src/bin/pg_version/pg_version.c b/src/bin/pg_version/pg_version.c index 3c7de9387f..541995ffca 100644 --- a/src/bin/pg_version/pg_version.c +++ b/src/bin/pg_version/pg_version.c @@ -7,14 +7,14 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/bin/pg_version/Attic/pg_version.c,v 1.8 1997/09/08 02:33:10 momjian Exp $ + * $Header: /cvsroot/pgsql/src/bin/pg_version/Attic/pg_version.c,v 1.9 1998/03/30 16:47:35 momjian Exp $ * *------------------------------------------------------------------------- */ #include <stdlib.h> #include <stdio.h> -#include <version.h> /* interface to SetPgVersion */ +#include "version.h" /* interface to SetPgVersion */ |