diff options
| author | Bruce Momjian | 2002-07-02 06:18:57 +0000 |
|---|---|---|
| committer | Bruce Momjian | 2002-07-02 06:18:57 +0000 |
| commit | c9a734521712797b1cd6a77bf9cabfe4c503e186 (patch) | |
| tree | 6650cb4bbb0932c47afc98ea73cb9fadc8f3a573 /src/backend | |
| parent | 22347d69c9de13ab97638931b4b9032fc123a54d (diff) | |
>the extra level of struct naming for pd_opaque has no obvious
>usefulness.
>
>> [...] should I post a patch that puts pagesize directly into
>> PageHeaderData?
>
>If you're so inclined. Given that pd_opaque is hidden in those macros,
>there wouldn't be much of any gain in readability either, so I haven't
>worried about changing the declaration.
Thanks for the clarification. Here is the patch. Not much gain, but at
least it saves the next junior hacker from scratching his head ...
Manfred Koizar
Diffstat (limited to 'src/backend')
| -rw-r--r-- | src/backend/access/hash/hashutil.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/backend/access/hash/hashutil.c b/src/backend/access/hash/hashutil.c index 1cc4a56993..224f28e6d5 100644 --- a/src/backend/access/hash/hashutil.c +++ b/src/backend/access/hash/hashutil.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/access/hash/hashutil.c,v 1.30 2002/06/20 20:29:24 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/access/hash/hashutil.c,v 1.31 2002/07/02 06:18:57 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -131,13 +131,13 @@ _hash_checkpage(Page page, int flags) HashPageOpaque opaque; Assert(page); - Assert(((PageHeader) (page))->pd_lower >= (sizeof(PageHeaderData) - sizeof(ItemIdData))); + Assert(((PageHeader) (page))->pd_lower >= SizeOfPageHeaderData); #if 1 Assert(((PageHeader) (page))->pd_upper <= (BLCKSZ - MAXALIGN(sizeof(HashPageOpaqueData)))); Assert(((PageHeader) (page))->pd_special == (BLCKSZ - MAXALIGN(sizeof(HashPageOpaqueData)))); - Assert(((PageHeader) (page))->pd_opaque.od_pagesize == BLCKSZ); + Assert(PageGetPageSize(page) == BLCKSZ); #endif if (flags) { |