diff options
| author | Bruce Momjian | 2001-03-22 06:16:21 +0000 |
|---|---|---|
| committer | Bruce Momjian | 2001-03-22 06:16:21 +0000 |
| commit | 0686d49da0a34ad92f61f791ea1039dec5d20f41 (patch) | |
| tree | 11c8f58fb4364f5904c3cbad5c7a28ccea5d4049 /src/backend/tcop | |
| parent | 9e1552607a9dc6bc23e43d46770a9063ade4f3f0 (diff) | |
Remove dashes in comments that don't need them, rewrap with pgindent.
Diffstat (limited to 'src/backend/tcop')
| -rw-r--r-- | src/backend/tcop/dest.c | 49 | ||||
| -rw-r--r-- | src/backend/tcop/fastpath.c | 8 | ||||
| -rw-r--r-- | src/backend/tcop/postgres.c | 273 | ||||
| -rw-r--r-- | src/backend/tcop/pquery.c | 99 | ||||
| -rw-r--r-- | src/backend/tcop/utility.c | 23 |
5 files changed, 206 insertions, 246 deletions
diff --git a/src/backend/tcop/dest.c b/src/backend/tcop/dest.c index 1bd4d2339e..0e9cdd2213 100644 --- a/src/backend/tcop/dest.c +++ b/src/backend/tcop/dest.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/tcop/dest.c,v 1.43 2001/03/22 03:59:47 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/tcop/dest.c,v 1.44 2001/03/22 06:16:17 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -97,34 +97,31 @@ BeginCommand(char *pname, { case Remote: case RemoteInternal: - /* ---------------- - * if this is a "retrieve into portal" query, done - * because nothing needs to be sent to the fe. - * ---------------- + + /* + * if this is a "retrieve into portal" query, done because + * nothing needs to be sent to the fe. */ CommandInfo[0] = '\0'; if (isIntoPortal) break; - /* ---------------- - * if portal name not specified for remote query, - * use the "blank" portal. - * ---------------- + /* + * if portal name not specified for remote query, use the + * "blank" portal. */ if (pname == NULL) pname = "blank"; - /* ---------------- - * send fe info on tuples we're about to send - * ---------------- + /* + * send fe info on tuples we're about to send */ pq_puttextmessage('P', pname); - /* ---------------- - * if this is a retrieve, then we send back the tuple - * descriptor of the tuples. "retrieve into" is an - * exception because no tuples are returned in that case. - * ---------------- + /* + * if this is a retrieve, then we send back the tuple + * descriptor of the tuples. "retrieve into" is an exception + * because no tuples are returned in that case. */ if (operation == CMD_SELECT && !isIntoRel) { @@ -151,9 +148,9 @@ BeginCommand(char *pname, break; case Debug: - /* ---------------- - * show the return type of the tuples - * ---------------- + + /* + * show the return type of the tuples */ if (pname == NULL) pname = "blank"; @@ -213,9 +210,9 @@ EndCommand(char *commandTag, CommandDest dest) { case Remote: case RemoteInternal: - /* ---------------- - * tell the fe that the query is over - * ---------------- + + /* + * tell the fe that the query is over */ sprintf(buf, "%s%s", commandTag, CommandInfo); pq_puttextmessage('C', buf); @@ -277,9 +274,9 @@ NullCommand(CommandDest dest) { case RemoteInternal: case Remote: - /* ---------------- - * tell the fe that we saw an empty query string - * ---------------- + + /* + * tell the fe that we saw an empty query string */ pq_putbytes("I", 2);/* note we send I and \0 */ break; diff --git a/src/backend/tcop/fastpath.c b/src/backend/tcop/fastpath.c index 0d83c5104c..56f13f9b8b 100644 --- a/src/backend/tcop/fastpath.c +++ b/src/backend/tcop/fastpath.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/tcop/fastpath.c,v 1.47 2001/03/22 03:59:47 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/tcop/fastpath.c,v 1.48 2001/03/22 06:16:17 momjian Exp $ * * NOTES * This cruft is the server side of PQfn. @@ -298,9 +298,9 @@ HandleFunctionRequest(void) * (including lookup of the given function ID) and elog if * appropriate. Unfortunately, because we cannot even read the * message properly without knowing whether the data types are - * pass-by-ref or pass-by-value, it's not all that easy to do :-(. - * The protocol should require the client to supply what it thinks is - * the typbyval and typlen value for each arg, so that we can read the + * pass-by-ref or pass-by-value, it's not all that easy to do :-(. The + * protocol should require the client to supply what it thinks is the + * typbyval and typlen value for each arg, so that we can read the * data without having to do any lookups. Then after we've read the * message, we should do the lookups, verify agreement of the actual * function arg types with what we received, and finally call the diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c index 745de3ce1a..b62b41356b 100644 --- a/src/backend/tcop/postgres.c +++ b/src/backend/tcop/postgres.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/tcop/postgres.c,v 1.213 2001/03/22 03:59:47 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/tcop/postgres.c,v 1.214 2001/03/22 06:16:17 momjian Exp $ * * NOTES * this is the "main" module of the postgres backend and @@ -157,9 +157,8 @@ InteractiveBackend(StringInfo inBuf) bool end = false; /* end-of-input flag */ bool backslashSeen = false; /* have we seen a \ ? */ - /* ---------------- - * display a prompt and obtain input from the user - * ---------------- + /* + * display a prompt and obtain input from the user */ printf("backend> "); fflush(stdout); @@ -172,10 +171,10 @@ InteractiveBackend(StringInfo inBuf) { if (UseNewLine) { - /* ---------------- - * if we are using \n as a delimiter, then read - * characters until the \n. - * ---------------- + + /* + * if we are using \n as a delimiter, then read characters + * until the \n. */ while ((c = getc(stdin)) != EOF) { @@ -208,9 +207,9 @@ InteractiveBackend(StringInfo inBuf) } else { - /* ---------------- - * otherwise read characters until EOF. - * ---------------- + + /* + * otherwise read characters until EOF. */ while ((c = getc(stdin)) != EOF) appendStringInfoChar(inBuf, (char) c); @@ -222,16 +221,14 @@ InteractiveBackend(StringInfo inBuf) if (end) return EOF; - /* ---------------- - * otherwise we have a user query so process it. - * ---------------- + /* + * otherwise we have a user query so process it. */ break; } - /* ---------------- - * if the query echo flag was given, print the query.. - * ---------------- + /* + * if the query echo flag was given, print the query.. */ if (EchoQuery) printf("query: %s\n", inBuf->data); @@ -260,9 +257,8 @@ SocketBackend(StringInfo inBuf) char qtype; char result = '\0'; - /* ---------------- - * get input from the frontend - * ---------------- + /* + * get input from the frontend */ qtype = '?'; if (pq_getbytes(&qtype, 1) == EOF) @@ -270,9 +266,9 @@ SocketBackend(StringInfo inBuf) switch (qtype) { - /* ---------------- - * 'Q': user entered a query - * ---------------- + + /* + * 'Q': user entered a query */ case 'Q': if (pq_getstr(inBuf)) @@ -280,9 +276,8 @@ SocketBackend(StringInfo inBuf) result = 'Q'; break; - /* ---------------- - * 'F': calling user/system functions - * ---------------- + /* + * 'F': calling user/system functions */ case 'F': if (pq_getstr(inBuf)) @@ -290,20 +285,18 @@ SocketBackend(StringInfo inBuf) result = 'F'; break; - /* ---------------- - * 'X': frontend is exiting - * ---------------- + /* + * 'X': frontend is exiting */ case 'X': result = 'X'; break; - /* ---------------- - * otherwise we got garbage from the frontend. + /* + * otherwise we got garbage from the frontend. * - * XXX are we certain that we want to do an elog(FATAL) here? - * -cim 1/24/90 - * ---------------- + * XXX are we certain that we want to do an elog(FATAL) here? + * -cim 1/24/90 */ default: elog(FATAL, "Socket command type %c unknown", qtype); @@ -350,15 +343,13 @@ pg_parse_and_rewrite(char *query_string, /* string to execute */ List *querytree_list; List *list_item; - /* ---------------- - * (1) parse the request string into a list of raw parse trees. - * ---------------- + /* + * (1) parse the request string into a list of raw parse trees. */ raw_parsetree_list = pg_parse_query(query_string, typev, nargs); - /* ---------------- - * (2) Do parse analysis and rule rewrite. - * ---------------- + /* + * (2) Do parse analysis and rule rewrite. */ querytree_list = NIL; foreach(list_item, raw_parsetree_list) @@ -424,9 +415,8 @@ pg_analyze_and_rewrite(Node *parsetree) Query *querytree; List *new_list; - /* ---------------- - * (1) Perform parse analysis. - * ---------------- + /* + * (1) Perform parse analysis. */ if (Show_parser_stats) ResetUsage(); @@ -440,12 +430,11 @@ pg_analyze_and_rewrite(Node *parsetree) ResetUsage(); } - /* ---------------- - * (2) Rewrite the queries, as necessary + /* + * (2) Rewrite the queries, as necessary * - * rewritten queries are collected in new_list. Note there may be - * more or fewer than in the original list. - * ---------------- + * rewritten queries are collected in new_list. Note there may be more + * or fewer than in the original list. */ new_list = NIL; foreach(list_item, querytree_list) @@ -567,9 +556,8 @@ pg_plan_query(Query *querytree) } #endif - /* ---------------- - * Print plan if debugging. - * ---------------- + /* + * Print plan if debugging. */ if (Debug_print_plan) { @@ -704,10 +692,10 @@ pg_exec_query_string(char *query_string, /* string to execute */ if (!allowit) { - /* ---------------- - * the EndCommand() stuff is to tell the frontend - * that the command ended. -cim 6/1/90 - * ---------------- + + /* + * the EndCommand() stuff is to tell the frontend that the + * command ended. -cim 6/1/90 */ char *tag = "*ABORT STATE*"; @@ -773,9 +761,9 @@ pg_exec_query_string(char *query_string, /* string to execute */ if (querytree->commandType == CMD_UTILITY) { - /* ---------------- - * process utility functions (create, destroy, etc..) - * ---------------- + + /* + * process utility functions (create, destroy, etc..) */ if (Debug_print_query) elog(DEBUG, "ProcessUtility: %s", query_string); @@ -786,9 +774,9 @@ pg_exec_query_string(char *query_string, /* string to execute */ } else { - /* ---------------- - * process a plannable query. - * ---------------- + + /* + * process a plannable query. */ Plan *plan; @@ -1201,18 +1189,18 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha break; case 'B': - /* ---------------- - * specify the size of buffer pool - * ---------------- + + /* + * specify the size of buffer pool */ if (secure) NBuffers = atoi(optarg); break; case 'C': - /* ---------------- - * don't print version string - * ---------------- + + /* + * don't print version string */ Noversion = true; break; @@ -1237,34 +1225,34 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha break; case 'E': - /* ---------------- - * E - echo the query the user entered - * ---------------- + + /* + * E - echo the query the user entered */ EchoQuery = true; break; case 'e': - /* -------------------------- + + /* * Use european date formats. - * -------------------------- */ EuroDates = true; break; case 'F': - /* -------------------- - * turn off fsync - * -------------------- + + /* + * turn off fsync */ if (secure) enableFsync = false; break; case 'f': - /* ----------------- - * f - forbid generation of certain plans - * ----------------- + + /* + * f - forbid generation of certain plans */ switch (optarg[0]) { @@ -1296,54 +1284,54 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha break; case 'L': - /* -------------------- - * turn off locking - * -------------------- + + /* + * turn off locking */ if (secure) lockingOff = 1; break; case 'N': - /* ---------------- - * N - Don't use newline as a query delimiter - * ---------------- + + /* + * N - Don't use newline as a query delimiter */ UseNewLine = 0; break; case 'O': - /* -------------------- - * allow system table structure modifications - * -------------------- + + /* + * allow system table structure modifications */ if (secure) /* XXX safe to allow from client??? */ allowSystemTableMods = true; break; case 'P': - /* -------------------- - * ignore system indexes - * -------------------- + + /* + * ignore system indexes */ if (secure) /* XXX safe to allow from client??? */ IgnoreSystemIndexes(true); break; case 'o': - /* ---------------- - * o - send output (stdout and stderr) to the given file - * ---------------- + + /* + * o - send output (stdout and stderr) to the given file */ if (secure) StrNCpy(OutputFileName, optarg, MAXPGPATH); break; case 'p': - /* ---------------- - * p - special flag passed if backend was forked - * by a postmaster. - * ---------------- + + /* + * p - special flag passed if backend was forked by a + * postmaster. */ if (secure) { @@ -1354,9 +1342,9 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha break; case 'S': - /* ---------------- - * S - amount of sort memory to use in 1k bytes - * ---------------- + + /* + * S - amount of sort memory to use in 1k bytes */ { int S; @@ -1368,15 +1356,15 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha break; case 's': - /* ---------------- - * s - report usage statistics (timings) after each query - * ---------------- + + /* + * s - report usage statistics (timings) after each query */ Show_query_stats = 1; break; case 't': - /* ---------------- + /* --------------- * tell postgres to report usage statistics (timings) for * each query * @@ -1411,9 +1399,9 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha break; case 'W': - /* ---------------- - * wait N seconds to allow attach from a debugger - * ---------------- + + /* + * wait N seconds to allow attach from a debugger */ sleep(atoi(optarg)); break; @@ -1715,7 +1703,7 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha if (!IsUnderPostmaster) { puts("\nPOSTGRES backend interactive interface "); - puts("$Revision: 1.213 $ $Date: 2001/03/22 03:59:47 $\n"); + puts("$Revision: 1.214 $ $Date: 2001/03/22 06:16:17 $\n"); } /* @@ -1810,11 +1798,10 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha parser_input = makeStringInfo(); - /* ---------------- - * (1) tell the frontend we're ready for a new query. + /* + * (1) tell the frontend we're ready for a new query. * - * Note: this includes fflush()'ing the last of the prior output. - * ---------------- + * Note: this includes fflush()'ing the last of the prior output. */ ReadyForQuery(whereToSendOutput); @@ -1823,11 +1810,10 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha else set_ps_display("idle"); - /* ---------------- - * (2) deal with pending asynchronous NOTIFY from other backends, - * and enable async.c's signal handler to execute NOTIFY directly. - * Then set up other stuff needed before blocking for input. - * ---------------- + /* + * (2) deal with pending asynchronous NOTIFY from other backends, + * and enable async.c's signal handler to execute NOTIFY directly. + * Then set up other stuff needed before blocking for input. */ QueryCancelPending = false; /* forget any earlier CANCEL * signal */ @@ -1840,25 +1826,22 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha QueryCancelPending = false; CHECK_FOR_INTERRUPTS(); - /* ---------------- - * (3) read a command (loop blocks here) - * ---------------- + /* + * (3) read a command (loop blocks here) */ firstchar = ReadCommand(parser_input); - /* ---------------- - * (4) disable async signal conditions again. - * ---------------- + /* + * (4) disable async signal conditions again. */ ImmediateInterruptOK = false; QueryCancelPending = false; /* forget any CANCEL signal */ DisableNotifyInterrupt(); - /* ---------------- - * (5) check for any other interesting events that happened - * while we slept. - * ---------------- + /* + * (5) check for any other interesting events that happened while + * we slept. */ if (got_SIGHUP) { @@ -1866,15 +1849,14 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha ProcessConfigFile(PGC_SIGHUP); } - /* ---------------- - * (6) process the command. - * ---------------- + /* + * (6) process the command. */ switch (firstchar) { - /* ---------------- - * 'F' indicates a fastpath call. - * ---------------- + + /* + * 'F' indicates a fastpath call. */ case 'F': /* start an xact for this function invocation */ @@ -1890,30 +1872,29 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha finish_xact_command(); break; - /* ---------------- - * 'Q' indicates a user query - * ---------------- + /* + * 'Q' indicates a user query */ case 'Q': if (strspn(parser_input->data, " \t\r\n") == parser_input->len) { - /* ---------------- - * if there is nothing in the input buffer, don't bother - * trying to parse and execute anything; just send - * back a quick NullCommand response. - * ---------------- + + /* + * if there is nothing in the input buffer, don't + * bother trying to parse and execute anything; just + * send back a quick NullCommand response. */ if (IsUnderPostmaster) NullCommand(Remote); } else { - /* ---------------- - * otherwise, process the input string. + + /* + * otherwise, process the input string. * - * Note: transaction command start/end is now done - * within pg_exec_query_string(), not here. - * ---------------- + * Note: transaction command start/end is now done within + * pg_exec_query_string(), not here. */ if (Show_query_stats) ResetUsage(); diff --git a/src/backend/tcop/pquery.c b/src/backend/tcop/pquery.c index 2dfc5a9ff1..48df3f980a 100644 --- a/src/backend/tcop/pquery.c +++ b/src/backend/tcop/pquery.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/tcop/pquery.c,v 1.43 2001/03/22 03:59:48 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/tcop/pquery.c,v 1.44 2001/03/22 06:16:17 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -55,15 +55,13 @@ CreateExecutorState(void) { EState *state; - /* ---------------- - * create a new executor state - * ---------------- + /* + * create a new executor state */ state = makeNode(EState); - /* ---------------- - * initialize the Executor State structure - * ---------------- + /* + * initialize the Executor State structure */ state->es_direction = ForwardScanDirection; state->es_range_table = NIL; @@ -85,9 +83,8 @@ CreateExecutorState(void) state->es_per_tuple_exprcontext = NULL; - /* ---------------- - * return the executor state structure - * ---------------- + /* + * return the executor state structure */ return state; } @@ -137,9 +134,8 @@ PreparePortal(char *portalName) { Portal portal; - /* ---------------- - * Check for already-in-use portal name. - * ---------------- + /* + * Check for already-in-use portal name. */ portal = GetPortalByName(portalName); if (PortalIsValid(portal)) @@ -154,9 +150,8 @@ PreparePortal(char *portalName) PortalDrop(&portal); } - /* ---------------- - * Create the new portal. - * ---------------- + /* + * Create the new portal. */ portal = CreatePortal(portalName); @@ -188,9 +183,8 @@ ProcessQuery(Query *parsetree, set_ps_display(tag = CreateOperationTag(operation)); - /* ---------------- - * initialize portal/into relation status - * ---------------- + /* + * initialize portal/into relation status */ isRetrieveIntoPortal = false; isRetrieveIntoRelation = false; @@ -219,10 +213,9 @@ ProcessQuery(Query *parsetree, } } - /* ---------------- - * If retrieving into a portal, set up the portal and copy - * the parsetree and plan into its memory context. - * ---------------- + /* + * If retrieving into a portal, set up the portal and copy the + * parsetree and plan into its memory context. */ if (isRetrieveIntoPortal) { @@ -238,40 +231,34 @@ ProcessQuery(Query *parsetree, */ } - /* ---------------- - * Now we can create the QueryDesc object. - * ---------------- + /* + * Now we can create the QueryDesc object. */ queryDesc = CreateQueryDesc(parsetree, plan, dest); - /* ---------------- - * When performing a retrieve into, we override the normal - * communication destination during the processing of the - * the query. This only affects the tuple-output function - * - the correct destination will still see BeginCommand() - * and EndCommand() messages. - * ---------------- + /* + * When performing a retrieve into, we override the normal + * communication destination during the processing of the the query. + * This only affects the tuple-output function - the correct + * destination will still see BeginCommand() and EndCommand() + * messages. */ if (isRetrieveIntoRelation) queryDesc->dest = None; - /* ---------------- - * create a default executor state. - * ---------------- + /* + * create a default executor state. */ state = CreateExecutorState(); - /* ---------------- - * call ExecStart to prepare the plan for execution - * ---------------- + /* + * call ExecStart to prepare the plan for execution */ attinfo = ExecutorStart(queryDesc, state); - /* ---------------- - * report the query's result type information - * back to the front end or to whatever destination - * we're dealing with. - * ---------------- + /* + * report the query's result type information back to the front end or + * to whatever destination we're dealing with. */ BeginCommand(NULL, operation, @@ -281,10 +268,9 @@ ProcessQuery(Query *parsetree, tag, dest); - /* ---------------- - * If retrieve into portal, stop now; we do not run the plan - * until a FETCH command is received. - * ---------------- + /* + * If retrieve into portal, stop now; we do not run the plan until a + * FETCH command is received. */ if (isRetrieveIntoPortal) { @@ -302,25 +288,22 @@ ProcessQuery(Query *parsetree, return; } - /* ---------------- - * Now we get to the important call to ExecutorRun() where we - * actually run the plan.. - * ---------------- + /* + * Now we get to the important call to ExecutorRun() where we actually + * run the plan.. */ ExecutorRun(queryDesc, state, EXEC_RUN, 0L); /* save infos for EndCommand */ UpdateCommandInfo(operation, state->es_lastoid, state->es_processed); - /* ---------------- - * Now, we close down all the scans and free allocated resources. - * ---------------- + /* + * Now, we close down all the scans and free allocated resources. */ ExecutorEnd(queryDesc, state); - /* ---------------- - * Notify the destination of end of processing. - * ---------------- + /* + * Notify the destination of end of processing. */ EndCommand(tag, dest); } diff --git a/src/backend/tcop/utility.c b/src/backend/tcop/utility.c index 370d2d3bac..ae6cd20a5d 100644 --- a/src/backend/tcop/utility.c +++ b/src/backend/tcop/utility.c @@ -10,7 +10,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/tcop/utility.c,v 1.108 2001/03/22 03:59:48 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/tcop/utility.c,v 1.109 2001/03/22 06:16:17 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -384,21 +384,21 @@ ProcessUtility(Node *parsetree, */ if (stmt->column == NULL) { - /* ---------------- - * rename relation + + /* + * rename relation * - * Note: we also rename the "type" tuple - * corresponding to the relation. - * ---------------- + * Note: we also rename the "type" tuple corresponding to + * the relation. */ renamerel(relname, /* old name */ stmt->newname); /* new name */ } else { - /* ---------------- - * rename attribute - * ---------------- + + /* + * rename attribute */ renameatt(relname, /* relname */ stmt->column, /* old att name */ @@ -923,9 +923,8 @@ ProcessUtility(Node *parsetree, break; } - /* ---------------- - * tell fe/be or whatever that we're done. - * ---------------- + /* + * tell fe/be or whatever that we're done. */ EndCommand(commandTag, dest); } |
