diff options
| author | Bruce Momjian | 2006-10-04 00:30:14 +0000 |
|---|---|---|
| committer | Bruce Momjian | 2006-10-04 00:30:14 +0000 |
| commit | f99a569a2ee3763b4ae174e81250c95ca0fdcbb6 (patch) | |
| tree | 76e6371fe8b347c73d7020c0bc54b9fba519dc10 /src/backend/rewrite | |
| parent | 451e419e9852cdf9d7e7cefc09d5355abb3405e9 (diff) | |
pgindent run for 8.2.
Diffstat (limited to 'src/backend/rewrite')
| -rw-r--r-- | src/backend/rewrite/rewriteDefine.c | 31 | ||||
| -rw-r--r-- | src/backend/rewrite/rewriteHandler.c | 64 | ||||
| -rw-r--r-- | src/backend/rewrite/rewriteManip.c | 7 | ||||
| -rw-r--r-- | src/backend/rewrite/rewriteRemove.c | 6 |
4 files changed, 55 insertions, 53 deletions
diff --git a/src/backend/rewrite/rewriteDefine.c b/src/backend/rewrite/rewriteDefine.c index 17f437c385..d4f9c7f1ff 100644 --- a/src/backend/rewrite/rewriteDefine.c +++ b/src/backend/rewrite/rewriteDefine.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/rewrite/rewriteDefine.c,v 1.114 2006/09/05 21:08:35 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/rewrite/rewriteDefine.c,v 1.115 2006/10/04 00:29:56 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -32,7 +32,7 @@ static void checkRuleResultList(List *targetList, TupleDesc resultDesc, - bool isSelect); + bool isSelect); static bool setRuleCheckAsUser_walker(Node *node, Oid *context); static void setRuleCheckAsUser_Query(Query *qry, Oid userid); @@ -286,7 +286,7 @@ DefineQueryRewrite(RuleStmt *stmt) */ if (!replace && event_relation->rd_rules != NULL) { - int i; + int i; for (i = 0; i < event_relation->rd_rules->numLocks; i++) { @@ -369,14 +369,14 @@ DefineQueryRewrite(RuleStmt *stmt) else { /* - * For non-SELECT rules, a RETURNING list can appear in at most one - * of the actions ... and there can't be any RETURNING list at all - * in a conditional or non-INSTEAD rule. (Actually, there can be - * at most one RETURNING list across all rules on the same event, - * but it seems best to enforce that at rule expansion time.) If - * there is a RETURNING list, it must match the event relation. + * For non-SELECT rules, a RETURNING list can appear in at most one of + * the actions ... and there can't be any RETURNING list at all in a + * conditional or non-INSTEAD rule. (Actually, there can be at most + * one RETURNING list across all rules on the same event, but it seems + * best to enforce that at rule expansion time.) If there is a + * RETURNING list, it must match the event relation. */ - bool haveReturning = false; + bool haveReturning = false; foreach(l, action) { @@ -387,7 +387,7 @@ DefineQueryRewrite(RuleStmt *stmt) if (haveReturning) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), - errmsg("cannot have multiple RETURNING lists in a rule"))); + errmsg("cannot have multiple RETURNING lists in a rule"))); haveReturning = true; if (event_qual != NULL) ereport(ERROR, @@ -478,7 +478,7 @@ checkRuleResultList(List *targetList, TupleDesc resultDesc, bool isSelect) ereport(ERROR, (errcode(ERRCODE_INVALID_OBJECT_DEFINITION), isSelect ? - errmsg("SELECT rule's target list has too many entries") : + errmsg("SELECT rule's target list has too many entries") : errmsg("RETURNING list has too many entries"))); attr = resultDesc->attrs[i - 1]; @@ -513,9 +513,9 @@ checkRuleResultList(List *targetList, TupleDesc resultDesc, bool isSelect) /* * Allow typmods to be different only if one of them is -1, ie, - * "unspecified". This is necessary for cases like "numeric", - * where the table will have a filled-in default length but the - * select rule's expression will probably have typmod = -1. + * "unspecified". This is necessary for cases like "numeric", where + * the table will have a filled-in default length but the select + * rule's expression will probably have typmod = -1. */ tletypmod = exprTypmod((Node *) tle->expr); if (attr->atttypmod != tletypmod && @@ -638,4 +638,5 @@ RenameRewriteRule(Oid owningRel, const char *oldName, heap_freetuple(ruletup); heap_close(pg_rewrite_desc, RowExclusiveLock); } + #endif diff --git a/src/backend/rewrite/rewriteHandler.c b/src/backend/rewrite/rewriteHandler.c index 1af5bd7e7f..81af9eebad 100644 --- a/src/backend/rewrite/rewriteHandler.c +++ b/src/backend/rewrite/rewriteHandler.c @@ -7,7 +7,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/rewrite/rewriteHandler.c,v 1.166 2006/09/02 17:06:52 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/rewrite/rewriteHandler.c,v 1.167 2006/10/04 00:29:56 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -43,13 +43,13 @@ static Query *rewriteRuleAction(Query *parsetree, bool *returning_flag); static List *adjustJoinTreeList(Query *parsetree, bool removert, int rt_index); static void rewriteTargetList(Query *parsetree, Relation target_relation, - List **attrno_list); + List **attrno_list); static TargetEntry *process_matched_tle(TargetEntry *src_tle, TargetEntry *prior_tle, const char *attrName); static Node *get_assignment_input(Node *node); static void rewriteValuesRTE(RangeTblEntry *rte, Relation target_relation, - List *attrnos); + List *attrnos); static void markQueryForLocking(Query *qry, bool forUpdate, bool noWait, bool skipOldNew); static List *matchLocks(CmdType event, RuleLock *rulelocks, @@ -431,10 +431,10 @@ rewriteRuleAction(Query *parsetree, } /* - * If rule_action has a RETURNING clause, then either throw it away - * if the triggering query has no RETURNING clause, or rewrite it to - * emit what the triggering query's RETURNING clause asks for. Throw - * an error if more than one rule has a RETURNING clause. + * If rule_action has a RETURNING clause, then either throw it away if the + * triggering query has no RETURNING clause, or rewrite it to emit what + * the triggering query's RETURNING clause asks for. Throw an error if + * more than one rule has a RETURNING clause. */ if (!parsetree->returningList) rule_action->returningList = NIL; @@ -443,7 +443,7 @@ rewriteRuleAction(Query *parsetree, if (*returning_flag) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), - errmsg("cannot have RETURNING lists in multiple rules"))); + errmsg("cannot have RETURNING lists in multiple rules"))); *returning_flag = true; rule_action->returningList = (List *) ResolveNew((Node *) parsetree->returningList, @@ -907,12 +907,12 @@ searchForDefault(RangeTblEntry *rte) foreach(lc, rte->values_lists) { - List *sublist = (List *) lfirst(lc); - ListCell *lc2; + List *sublist = (List *) lfirst(lc); + ListCell *lc2; foreach(lc2, sublist) { - Node *col = (Node *) lfirst(lc2); + Node *col = (Node *) lfirst(lc2); if (IsA(col, SetToDefault)) return true; @@ -952,15 +952,15 @@ rewriteValuesRTE(RangeTblEntry *rte, Relation target_relation, List *attrnos) newValues = NIL; foreach(lc, rte->values_lists) { - List *sublist = (List *) lfirst(lc); - List *newList = NIL; - ListCell *lc2; - ListCell *lc3; + List *sublist = (List *) lfirst(lc); + List *newList = NIL; + ListCell *lc2; + ListCell *lc3; forboth(lc2, sublist, lc3, attrnos) { - Node *col = (Node *) lfirst(lc2); - int attrno = lfirst_int(lc3); + Node *col = (Node *) lfirst(lc2); + int attrno = lfirst_int(lc3); if (IsA(col, SetToDefault)) { @@ -972,7 +972,7 @@ rewriteValuesRTE(RangeTblEntry *rte, Relation target_relation, List *attrnos) if (!att_tup->attisdropped) new_expr = build_column_default(target_relation, attrno); else - new_expr = NULL; /* force a NULL if dropped */ + new_expr = NULL; /* force a NULL if dropped */ /* * If there is no default (ie, default is effectively NULL), @@ -1548,8 +1548,8 @@ RewriteQuery(Query *parsetree, List *rewrite_events) RangeTblEntry *values_rte = NULL; /* - * If it's an INSERT ... VALUES (...), (...), ... - * there will be a single RTE for the VALUES targetlists. + * If it's an INSERT ... VALUES (...), (...), ... there will be a + * single RTE for the VALUES targetlists. */ if (list_length(parsetree->jointree->fromlist) == 1) { @@ -1567,7 +1567,7 @@ RewriteQuery(Query *parsetree, List *rewrite_events) if (values_rte) { - List *attrnos; + List *attrnos; /* Process the main targetlist ... */ rewriteTargetList(parsetree, rt_entry_relation, &attrnos); @@ -1638,11 +1638,11 @@ RewriteQuery(Query *parsetree, List *rewrite_events) } /* - * If there is an INSTEAD, and the original query has a RETURNING, - * we have to have found a RETURNING in the rule(s), else fail. - * (Because DefineQueryRewrite only allows RETURNING in unconditional - * INSTEAD rules, there's no need to worry whether the substituted - * RETURNING will actually be executed --- it must be.) + * If there is an INSTEAD, and the original query has a RETURNING, we + * have to have found a RETURNING in the rule(s), else fail. (Because + * DefineQueryRewrite only allows RETURNING in unconditional INSTEAD + * rules, there's no need to worry whether the substituted RETURNING + * will actually be executed --- it must be.) */ if ((instead || qual_product != NULL) && parsetree->returningList && @@ -1653,22 +1653,22 @@ RewriteQuery(Query *parsetree, List *rewrite_events) case CMD_INSERT: ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), - errmsg("cannot INSERT RETURNING on relation \"%s\"", - RelationGetRelationName(rt_entry_relation)), + errmsg("cannot INSERT RETURNING on relation \"%s\"", + RelationGetRelationName(rt_entry_relation)), errhint("You need an unconditional ON INSERT DO INSTEAD rule with a RETURNING clause."))); break; case CMD_UPDATE: ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), - errmsg("cannot UPDATE RETURNING on relation \"%s\"", - RelationGetRelationName(rt_entry_relation)), + errmsg("cannot UPDATE RETURNING on relation \"%s\"", + RelationGetRelationName(rt_entry_relation)), errhint("You need an unconditional ON UPDATE DO INSTEAD rule with a RETURNING clause."))); break; case CMD_DELETE: ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), - errmsg("cannot DELETE RETURNING on relation \"%s\"", - RelationGetRelationName(rt_entry_relation)), + errmsg("cannot DELETE RETURNING on relation \"%s\"", + RelationGetRelationName(rt_entry_relation)), errhint("You need an unconditional ON DELETE DO INSTEAD rule with a RETURNING clause."))); break; default: diff --git a/src/backend/rewrite/rewriteManip.c b/src/backend/rewrite/rewriteManip.c index ce951a4601..96bfdf5f3a 100644 --- a/src/backend/rewrite/rewriteManip.c +++ b/src/backend/rewrite/rewriteManip.c @@ -7,7 +7,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/rewrite/rewriteManip.c,v 1.101 2006/07/14 14:52:22 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/rewrite/rewriteManip.c,v 1.102 2006/10/04 00:29:56 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -984,10 +984,11 @@ ResolveNew(Node *node, int target_varno, int sublevels_up, { if (IsA(result, Query)) ((Query *) result)->hasSubLinks = true; + /* * Note: if we're called on a non-Query node then it's the caller's - * responsibility to update hasSubLinks in the ancestor Query. - * This is pretty fragile and perhaps should be rethought ... + * responsibility to update hasSubLinks in the ancestor Query. This is + * pretty fragile and perhaps should be rethought ... */ } diff --git a/src/backend/rewrite/rewriteRemove.c b/src/backend/rewrite/rewriteRemove.c index f08001ce03..d09b5d2c42 100644 --- a/src/backend/rewrite/rewriteRemove.c +++ b/src/backend/rewrite/rewriteRemove.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/rewrite/rewriteRemove.c,v 1.67 2006/10/03 21:21:36 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/rewrite/rewriteRemove.c,v 1.68 2006/10/04 00:29:56 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -35,7 +35,7 @@ */ void RemoveRewriteRule(Oid owningRel, const char *ruleName, DropBehavior behavior, - bool missing_ok) + bool missing_ok) { HeapTuple tuple; Oid eventRelationOid; @@ -54,7 +54,7 @@ RemoveRewriteRule(Oid owningRel, const char *ruleName, DropBehavior behavior, */ if (!HeapTupleIsValid(tuple)) { - if (! missing_ok) + if (!missing_ok) ereport(ERROR, (errcode(ERRCODE_UNDEFINED_OBJECT), errmsg("rule \"%s\" for relation \"%s\" does not exist", |
