| Age | Commit message (Collapse) | Author |
|---|
|
The addition of support for PostgreSQL 9.6 and above neglected to change the `Postgres94` class to inherit from `Postgres95` instead of the latest `Postgres` class. This change restores the chain of inheritance, so that `Postgres94` and classes below see overridden methods from `Postgres95` and above.
|
|
Based on code and suggestions from @cathysax, ultimately I used the internal
pg_has_role function to test whether a user has ownership rights based on
group membership. I actually check for 'USAGE' rights, since that implies the
role has rights without need to `set role`, which users wouldn't be able to do
with a normal PPA login. Loosely tested back to 9.5.
This fixes https://github.com/phppgadmin/phppgadmin/issues/102
|
|
For version 14, we point to the /devel/ docs, since that version is currently
in dev. I also bumped the fall through to point to v14, arguably we could
instead point to /current/, but any current version will work, so I think
devel is more likely.
|
|
- Replaced .click(function) by .on('click', function)
- Replaced .click() by .trigger('click')
- Replaced .live(event, function) by .on(event, function)
- Replaced $(document).ready(function) by $(function)
- Replaced .bind/.unbind by .on/.off
- Replaced keypress events by keydown events, so that up/down keys get
supported again.
Thanks to the jquery-migrate project.
|
|
|
|
This is mostly just refactoring Nirgals patch to use a standard
capability function. I also short-circuited default_with_oid check since it
will always show false in >=PG12, so this saves a round trip. This also adds
a comment in the config file that show oids is no longer supported. This
could lead to a slight difference in running instalations, but since it
does not affect any code/behavior, not going to bump the config version.
|
|
Notes:
- "CREATE TABLE WITHOUT OIDS" continues to work, for now
- "SHOW default_with_oids" continues to work, for now
|
|
|
|
|
|
|
|
|
|
This fixes https://sourceforge.net/p/phppgadmin/bugs/422/ :
substr truncates on a byte-level, sometimes within a multi-byte character. This resulted in the whole string sometime not being displayed. See the original bug report for a way to reproduce.
Please note that this requires php-mbstring to be installed. This is usually the case, but the dependency should be described in the INSTALL file or something.
|
|
In the left tree, in tables and views, when one click on the + of browse, a message like "Erreur lors du chargement display.php?action=tree&return=schema&subject=view&view=test+vue&server=localhost%3A5432%3Aallow&database=bug422&schema=public (200: OK)" is displayed.
These items don't support tree actions, and the tree expansion should be be offered in the first place.
|
|
Whilst fixing the sequence group viewing bug, noticed that sequence properties
in general would throw an error if you did not have appropriate permissions.
While this is similar to permission denied errors when looking directly at
a sequence, there is other information to be exposed which is accesible
through pg_sequence and pg_sequences. The change implements a method for
determining if a user can access the sequence directly (ie. select * from seq)
and if so, include that information in the output. If not, we null those
columns.
This also fixes cases where last_value information is not visible due to a
sequence not haveing been "read" yet. ie. after sequence creation, or anytime
a sequence is altered, and nextval/setval hasn't been called.
This problem seems to go back to at least postgres 9, so I've mainlined the fix.
It might break on older unsupported versions of postgres; if someone wants to
fix that well... patches welcome.
|
|
While I have implemented this fix against Postgres 12, as far as I can tell,
this bug existed since 7.x, so I'm adding it to all versions back to 7.4
(when we did the class re-org). This could probably use more testing on older
versions though.
Thanks to Carlos Martinez for the bug report and reproducible test case!
|
|
Fix based on patches from @nirgal and @LuckySB
Reported at:
https://sourceforge.net/p/phppgadmin/bugs/448/
https://bugs.debian.org/762378
https://github.com/phppgadmin/phppgadmin/pull/27
https://github.com/phppgadmin/phppgadmin/pull/30
|
|
chmod -x all php files without a #!
chmod +x those with one.
|
|
window functions, breaking functions, aggregates, and object look-up within
PPA. This commit fixes all three of these areas. In theory we should probably
add some display bits to help users differentiate between these different
types in the UI, but this at least makes the system work again.
Thanks to @decodeJarvis who initially reported the problem and provided a
proposed fix (see PR#24 on the xzilla repo). Since we needed a more
comprehensive fix, I didn't use the code, but his patch was useful for getting
started.
|
|
|
|
called statically
|
|
|
|
Fixed Error Line 686
|
|
supported versions.
|
|
|
|
Fix by timding and ronlm
|
|
tables/views, and insert to tables. Based on patch by firzen, with additional work by xzilla
|
|
|
|
|
|
fields. Inspired by patch from Felipe Figueroa <amenadiel@gmail.com>
|
|
Dynamic themes applies the current main frame theme to the browser
tree frame without checking if it actually exists in the current
window.
Thispatch fix the resulting javascript error, breaking any other
following code.
|
|
https://sourceforge.net/p/phppgadmin/bugs/444/
|
|
|
|
|
|
thrown when a class is not specified, and it fixes it so that the broken admin tests pass. I'm pretty sure that ultimately we will want a better fix than this, but I'm taking the progress when I can get it. AFAICT the affore mentioned problems were introduced in https://github.com/phppgadmin/phppgadmin/commit/4680728829d8f95e29514512c9e94bb5345aa58a. If that was something you wanted, it's quite possibly broken now.
|
|
Error: Divid By Zero
|
|
Based on work by Bert Thomas <bthomas@brothom.nl>
|
|
|
|
|
|
|
|
connection
Based on Julien Rouhaud patch.
|
|
See discussion on bug #441:
http://sourceforge.net/p/phppgadmin/bugs/441/
|
|
|
|
Also add in the waiting option, making it work back to at least 8.1
|
|
|
|
Fix bugs introduced in commit d571ecae7b by ioguix on 2012-09-21.
I can't tell why these changes crept in along with the rest of
the fixes in that commit. It looks like a testing version was
committed.
|
|
|
|
It only concerns an fatal error message, no bad impacts
|
|
exception if needed.
This is usefull if a plugin don't want to start for some reasons.
Throwing an exception from the plugin constructors allows to remove this
plugin entirely during the script execution.
|
|
Allows to perform actions before beeing logged out.
|
|
Allows to add tags in <head /> from plugins
|
