diff options
| author | Taiki Koshino | 2025-09-10 06:28:01 +0000 |
|---|---|---|
| committer | Taiki Koshino | 2025-09-10 06:28:01 +0000 |
| commit | 58446a66f8d7f461de0407f41a15e8fd9fe9035c (patch) | |
| tree | 1638d93c374dc8e07270b920ffa63a6e07cfed18 | |
| parent | e7068df01f8d6fcb869dcd1e1e8a8c879863c85a (diff) | |
Fix safer directory deletion in Bash in recovery_1st_stage.sample.
Quote variables in rm commands to avoid accidental deletion:
rm -rf "${DEST_NODE_PGDATA}"
If the variable is empty, rm could delete unexpected files or directories.
| -rwxr-xr-x | src/sample/scripts/recovery_1st_stage.sample | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/sample/scripts/recovery_1st_stage.sample b/src/sample/scripts/recovery_1st_stage.sample index f62500f47..9cbe33c8a 100755 --- a/src/sample/scripts/recovery_1st_stage.sample +++ b/src/sample/scripts/recovery_1st_stage.sample @@ -49,7 +49,7 @@ ssh -T ${SSH_OPTIONS} ${POSTGRESQL_STARTUP_USER}@$DEST_NODE_HOST " set -o errexit - [ -d \"${DEST_NODE_PGDATA}\" ] && rm -rf ${DEST_NODE_PGDATA} + [ -d \"${DEST_NODE_PGDATA}\" ] && rm -rf \"${DEST_NODE_PGDATA}\" ${PGHOME}/bin/pg_basebackup -h $PRIMARY_NODE_HOST -U $REPLUSER -p $PRIMARY_NODE_PORT -D $DEST_NODE_PGDATA -X stream |