diff options
| author | Magnus Hagander | 2025-05-27 12:29:10 +0000 |
|---|---|---|
| committer | Magnus Hagander | 2025-05-27 12:29:10 +0000 |
| commit | d6250687da42786374caa956c9ef158ed313d630 (patch) | |
| tree | 7b949c9bf666b1c25e34f22d17df130dc34287ae | |
| parent | de4e82c2d1cbe9cefdba36d0d05700af9e99f76c (diff) | |
Properly remove "confirm preview" checkbox on broken uploads
When an image uploaded as a sponsor benefit was broken (unparseable), we
would incorrectly still show the "confirm preview looks ok" checkbox
below the error message. If the user confirmed that the preview (which
was non-existant and replaced with an error message) looked OK, we would
store an empty image in the database and consider the benefit OK.
Instead, we're of course not supposed to show the preview checkbox at
all if the image uploaded is broken.
| -rw-r--r-- | postgresqleu/confsponsor/benefitclasses/imageupload.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/postgresqleu/confsponsor/benefitclasses/imageupload.py b/postgresqleu/confsponsor/benefitclasses/imageupload.py index 6e5afc27..e951145f 100644 --- a/postgresqleu/confsponsor/benefitclasses/imageupload.py +++ b/postgresqleu/confsponsor/benefitclasses/imageupload.py @@ -75,7 +75,8 @@ class ImageUploadForm(BaseBenefitForm): if 'image' not in self._errors: # Unless there is an error already flagged in the clean_image method self._errors['image'] = self.error_class(['This field is required']) - self._delete_stage2_fields() + + self._delete_stage2_fields() return self.cleaned_data |