Age | Commit message (Collapse) | Author |
|
|
|
|
|
Patch in 2e41b31654b80aeb3e6037fc0b31422c951040c7 only handled From and
missed the ohher tields. To make this cleaner, move the escpaping code
into the UserWrapper class.
Reported by Dagfinn Ilmari Mannsåker, but not using his patch
|
|
|
|
We need to treat them as structured and escape only the name, not the
email part.
Reported by Dagfinn Ilmari Mannsåker
|
|
This changed back when we upgraded django, but this error path is
clearly very seldomly hit.
|
|
They go in different orders in the two, so fully specify them to make it
super clear.
|
|
|
|
|
|
|
|
This adds the Cc field when using the Review or the Comment function on
the website, and will add a list of all listed authors of the patch to
this. Should help people highlight it in their inboxes.
Suggested by José Luis Tallón
|
|
|
|
|
|
So a patch that's in "ready for committer" status remains there.
When doing this, also refuse to move any patches that are not either
"waiting for review" or "ready for committer". They will have to have
their existing status changed first, and then be moved.
|
|
|
|
Userprofiles aren't set for everbody, so catch a missing exception and
just ignore it since we know a user without a profile didn't specifically
ask to get notified (as that's stored in the profile).
|
|
Intended to be run manually, but to make life easier at least.
|
|
This makes it possible to receive notifications (via email) when a patch
has been updated.
It's possible to subscribe to notifications on a specific patch. It is also
possible to set the user profile up so that one receives notifications for
all patches where one is author, reviewer or committer on.
Notifications are, of course, only sent when other people make modifications
to the entry.
|
|
|
|
Should've been done with the migration to django 1.8, but better late
than never...
|
|
|
|
Newer djangos give warnings about this...
|
|
Per request during Brussels developer meeting
|
|
As requested by Jim Nasby and Alvaro Herrera
|
|
|
|
Grouped by each contriubtor, show which patches this person is the
author and reviewer of, to compare how many of each people have.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Somehow this worked on 1.4, probably by accident
|
|
|
|
Avoids one import...
T#
|
|
|
|
Needed for django 1.8
|
|
Noted by Erik Rijkers
|
|
Account for the Committer column added in 8495806.
|
|
Pointed out by Andres that the original patch only did the CF
listing, and not the actual patch viewing.
|
|
Per request
|
|
This is an incorrect state, but we shouldn't crash anyway. Instead show
an error message and redirect to the root page.
Reported by Bruce Momjian
|
|
Exceptions will not show the actual error message on the site, only
send an email to the admins with it. Thus, anything that can normally
happen due to a user error should not use that. Instead of that, use
the messages framework so it renders on the next page.
|
|
|
|
|
|
feedback"
Returned with Feedback will now actually close the patch and *not* move it to
the next CF. Since it used to do that, all existing Returned with Feedback patches
are changed to Moved to next CF which does the same thing that Returned with
Feedback used to do. And of course, Moved to next CF is a new option available for
each patch from now on.
|
|
Instead of raising an exception which will cause both a server log
and an email to be sent, return a proper http 400 message when the
incoming authentication request is bad. This will also show the
proper error message to the client, instead of a generic internal
server error.
|
|
Without this, once a patch was closed (rejected/committed etc),
it was no longer possible to undo that and reopen it.
We now allow this to be done in the very last commitfest a patch
is on. We cannot change it on a previous commitfest, as that could
end up with the patch being open in two CFs at the same time, but
there is no reason it shouldn't be doable in the last one.
|
|
|