diff options
| author | Magnus Hagander | 2018-09-16 21:47:52 +0000 |
|---|---|---|
| committer | Magnus Hagander | 2018-09-16 21:49:51 +0000 |
| commit | 84151808c02beacac4395c506189ee743bc9f260 (patch) | |
| tree | aa101a06132452736be1443d0158f68e803ec6a3 /pgcommitfest/commitfest/views.py | |
| parent | 1d248d208910f672bf214141cd964fd5285e0a8e (diff) | |
Don't fail on incorrect statuses in URL
The comment said we should ignore the status if int() on it fails, but
to do that we have to fail it before we actually add the WHERE clause.
Thus, reorder the code to do so.
Diffstat (limited to 'pgcommitfest/commitfest/views.py')
| -rw-r--r-- | pgcommitfest/commitfest/views.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pgcommitfest/commitfest/views.py b/pgcommitfest/commitfest/views.py index 3ee60e3..cc94950 100644 --- a/pgcommitfest/commitfest/views.py +++ b/pgcommitfest/commitfest/views.py @@ -108,8 +108,8 @@ def commitfest(request, cfid): whereparams = {} if request.GET.has_key('status') and request.GET['status'] != "-1": try: - whereclauses.append("poc.status=%(status)s") whereparams['status'] = int(request.GET['status']) + whereclauses.append("poc.status=%(status)s") except ValueError: # int() failed -- so just ignore this filter pass |