Clean up test_ifaddrs a bit.

We customarily #include <netinet/in.h> before <arpa/inet.h>; according
to our git history (cf commit 527f8babc) there used to be platform(s)
where <arpa/inet.h> didn't compile otherwise.  That's probably not
really an issue anymore, but since test_ifaddrs.c is the one and only
place in our code that's not following that rule, bring it into line.
Also remove #include <sys/socket.h>, as that's duplicative given that
libpq/ifaddr.h does so (via pqcomm.h).

In passing, add a .gitignore file so nobody accidentally commits the
test_ifaddrs executable, as I nearly did.

I see no particular need to back-patch this, as it's just neatnik-ism
considering we don't build test_ifaddrs by default, or even document
it anywhere.

diff --git a/src/tools/ifaddrs/.gitignore b/src/tools/ifaddrs/.gitignore
new file mode 100644 (file)
index 0000000..2e90032
--- /dev/null
+++ b/src/tools/ifaddrs/.gitignore
@@ -0,0 +1 @@
+/test_ifaddrs

diff --git a/src/tools/ifaddrs/test_ifaddrs.c b/src/tools/ifaddrs/test_ifaddrs.c
index 80b9bb026604d06d3564e827dd935837d7ee4558..100359ade1242b169afb98dae363fb8e507dcc2b 100644 (file)
--- a/src/tools/ifaddrs/test_ifaddrs.c
+++ b/src/tools/ifaddrs/test_ifaddrs.c
@@ -8,9 +8,8 @@
 
 #include "postgres.h"
 
-#include <arpa/inet.h>
 #include <netinet/in.h>
-#include <sys/socket.h>
+#include <arpa/inet.h>
 
 #include "libpq/ifaddr.h"