Fixed update script for PMD #12

Merged

abobov merged 1 commit from fix-update into main

2025-03-10 17:45:51 +01:00

abobov commented

2025-03-06 19:20:41 +01:00

(Migrated from github.com)

Starting from PMD 7.11.0, assets are now signed, which broke the PMD update script.

The script was finding more than one asset (pmd-dist-VERSION-bin.zip and pmd-dist-VERSION-bin.zip.asc). To address this, I replaced the contains check with a `test (regexp) to ensure the correct asset is selected. Additionally, I updated the Checkstyle script in the same manner as a precautionary measure.

I also think adding a manual run option for the workflow could be a good idea. This would allow us to trigger the update process on demand when needed.

Starting from [PMD 7.11.0](https://github.com/pmd/pmd/commit/dd54ddf5062f7f56afe589b7ac6043f253d006f9), assets are now [signed](https://github.com/pmd/pmd/releases/tag/pmd_releases%2F7.11.0#signed-releases), which broke the PMD [update script](https://github.com/gherynos/pre-commit-java/actions/runs/13614143779/job/38055017070). The script was finding more than one asset (`pmd-dist-VERSION-bin.zip` and `pmd-dist-VERSION-bin.zip.asc`). To address this, I replaced the `contains` check with a `test (regexp) to ensure the correct asset is selected. Additionally, I updated the Checkstyle script in the same manner as a precautionary measure. I also think adding a manual run option for the workflow could be a good idea. This would allow us to trigger the update process on demand when needed.

gherynos commented

2025-03-10 17:45:40 +01:00

(Migrated from github.com)

Thank you very much @abobov 😃 Yep, manual execution of the workflow sounds good, I'll add the dispatch trigger

Thank you very much @abobov 😃 Yep, manual execution of the workflow sounds good, I'll add the `dispatch` trigger

❤️ 1