back to square 1 on TRSP code for version 2.4.0

Question

Maybe trying to fix the warnings, I messed a little with the code. (it crashes the server sometimes) So, using the original code (that includes the via) and letting the warnings live will be best. (I don't know if that will crash the server sometimes, but Its worth the try)

And, keeping the wrappers when there are no restrictions. (unless the not so shortest paths is ok)

I need opinions.

links that might help to decide: https://travis-ci.org/cvvergara/pgrouting/jobs/189902506#L772 https://ci.appveyor.com/project/cvvergara/pgrouting/build/2.4.728

note that on travis:

ERROR:  could not load library "/usr/lib/postgresql/9.6/lib/libpgrouting-2.4.so": /usr/lib/postgresql/9.6/lib/libpgrouting-2.4.so: undefined symbol: heap_formtuple

is not letting the library to be built correctly Task while I get comments about this topic: - [x] fix the : undefined symbol: heap_formtuple - [x] Comment on this issue the new links once the library is build in its fullest

该提问来源于开源项目：pgRouting/pgrouting

Answer 1

After fixing the heap_form_tuple it compiles and tests are executed: - travis: - compilation - visual tests - pgtap tests - appveyor - compilation fails

From travis visual tests: the expected results get substitued with |||

< 0|2|4|1
< 1|5|10|1
< 2|10|12|1
< 3|11|11|1
< 4|6|8|1
< 5|5|7|1
< 6|8|6|1
< 7|7|-1|0
< 0|7|6|1
< 1|8|7|1
< 2|5|8|1
< 3|6|9|1
< 4|9|15|1
< 5|12|13|1
< 6|11|-1|0
---
> |||
> |||
> |||
> |||
> |||
> |||
> |||
> |||
> |||
> |||
> |||
> |||
> |||
> |||
> |||

tasks to do while I get comments about this topic:

• Posgres expect a value false on nulls to be of type bool not of type char (here) https://github.com/cvvergara/pgrouting/blob/trsp/v2.1.0/src/trsp/src/trsp.c#L656
• [ ] change the type to bool
• [ ] instead of ' ' use false
• [ ] Comment on this issue after making the changes