weixin_39987138 2020-11-20 21:15
浏览 0

Dereferancing null Value in File fluid_cmd.c

In the file fluid_cmd.c at line number 696 the function, fluid_synth_get_sfont can return null. Hence it should be null checked before use. This error is reported by prevent static code analysis tool.

Attaching the required patch.

Reported by: jaiveerrathi

Original Ticket: fluidsynth/tickets/139

该提问来源于开源项目:FluidSynth/fluidsynth

  • 写回答

5条回答 默认 最新

  • weixin_39987138 2020-11-20 21:15
    关注

    Hi and thanks for the patch!

    A few nitpicks: - so that it applies to git master ( https://sourceforge.net/p/fluidsynth/code-git/ci/master/tree/ ) - coding style fix "if(sfont){" -> "if (sfont) {" - commit message: "Fix Dereferencing NULLVal-fluid_cmd" -> "Check for NULL sfont in fluid_handle_fonts" and in the message "Closes ticket #139".

    Would you like to resubmit a fixed patch, or should I just fix that up for you and commit it?

    Original comment by: diwic

    评论

报告相同问题?