Skip to content

Add disk autoscale configuration parameters in compute and disk settings #32628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 14, 2025

Conversation

joshenlim
Copy link
Member

@joshenlim joshenlim commented Jan 7, 2025

Related API PR: https://github.com/supabase/infrastructure/pull/20478 (Already deployed)

Adds 3 configurable parameters to control disk autoscaling under "Compute and Disk" -> "Advanced disk settings"
image

These parameters can be configured anytime with no cooldown, unlike the disk storage settings
Descriptions are dynamic to make it clearer what they do, and Admonition at the bottom as a summary of the autoscaling config behaviour

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 9:16am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 9:16am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 9:16am
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 9:16am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 9:16am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 9:16am

@joshenlim joshenlim requested a review from a team as a code owner January 7, 2025 15:44
Copy link

supabase bot commented Jan 7, 2025

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Copy link

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small rounding issue:
Screenshot 2025-01-08 at 18 41 37

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IOPS settings are editable and show errors even though I'm not on large
Screenshot 2025-01-08 at 18 42 31

@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com January 8, 2025 12:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs January 8, 2025 12:36 Inactive
@joshenlim
Copy link
Member Author

Pushed up fixes for the 2 issues identified! 🙏

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Tested on preview

@joshenlim joshenlim merged commit c388cbe into master Jan 14, 2025
15 checks passed
@joshenlim joshenlim deleted the chore/add-disk-autoscale-configuration-parameters branch January 14, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants