Skip to content

Enable branching for vercel marketplace #32396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

kamilogorek
Copy link
Member

@kamilogorek kamilogorek commented Dec 30, 2024

Rework vercel integration section, remove resync button, remove restrictions in few places.

Corresponding API that needs to be deployed before shipping this https://github.com/supabase/infrastructure/pull/21074

Screenshot 2024-12-30 at 17 40 02 Screenshot 2024-12-30 at 17 40 06

@kamilogorek kamilogorek requested a review from a team as a code owner December 30, 2024 17:50
Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 4:24am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 4:24am
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 4:24am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) Jan 2, 2025 4:24am
studio-self-hosted ⬜️ Ignored (Inspect) Jan 2, 2025 4:24am
zone-www-dot-com ⬜️ Skipped (Inspect) Jan 2, 2025 4:24am

Copy link

supabase bot commented Dec 30, 2024

This pull request has been ignored for the connected project xguihxuzqibwxjnimxev because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Tested on preview

@@ -195,8 +193,6 @@ const CreateProject = () => {
},
orgSlug: selectedOrganization?.slug,
})

await syncEnvs({ connectionId })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this has been removed because it now happens automatically / is no longer needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was always syncing on creation time, not sure why we ever synced twice 😅

@kamilogorek kamilogorek merged commit 06c3a3e into master Jan 6, 2025
17 of 18 checks passed
@kamilogorek kamilogorek deleted the enable-branching-for-vercel-marketplace branch January 6, 2025 09:15
ibixler pushed a commit to Music-Visualization-MQP/supabase that referenced this pull request Jan 11, 2025
* feat: Add support for branching for Vercel Marketplace resources

* docs: Remove Vercel Marketplace branching support note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants