gnodet commented on code in PR #13241:
URL: https://github.com/apache/maven/pull/13241#discussion_r4073912813
##########
impl/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java:
##########
@@ -141,6 +140,7 @@ private Result<ProjectDependencyGraph>
reactorDependencyGraph(MavenSession sessi
trimSelectedProjects(activeProjects, allSortedProjects,
projectDependencyGraph, session.getRequest());
activeProjects = trimResumedProjects(activeProjects,
projectDependencyGraph, session.getRequest());
activeProjects = trimExcludedProjects(activeProjects,
projectDependencyGraph, session.getRequest());
+ validateExtensionIsNotPartOfReactor(activeProjects, projects,
session.getRequest());
Review Comment:
The name `validateExtensionIsNotPartOfReactor` reads as *"check that an
extension is absent from the reactor"*, but what the method actually does is
*"check that no active project uses as an extension another project that is
also part of the active reactor build"*. A more accurate name, and renaming the
first parameter to `activeProjects` to match its meaning:
```suggestion
validateReactorExtensionNotUsedInActiveReactor(activeProjects,
projects, session.getRequest());
```
##########
impl/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java:
##########
@@ -376,15 +376,17 @@ private List<MavenProject>
getProjectsForMavenReactor(MavenSession session) thro
return requestPomCollectionStrategy.collectProjects(request);
}
- private void validateProjects(List<MavenProject> projects,
MavenExecutionRequest request)
+ private void validateExtensionIsNotPartOfReactor(
+ List<MavenProject> projects, List<MavenProject> allProjects,
MavenExecutionRequest request)
Review Comment:
Same rename here, plus `projects` → `activeProjects` for the first parameter
(it receives the already-trimmed active reactor, while `allProjects` is the
full collected set):
```suggestion
private void validateReactorExtensionNotUsedInActiveReactor(
List<MavenProject> activeProjects, List<MavenProject>
allProjects, MavenExecutionRequest request)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
