Skip to content

Account for end date in additional_purchased_storage_size

Suraj Tripathi requested to merge issue_410281_ff_storage_expiry_fix into master

What does this MR do and why?

The "storage_limit" we use to display notification and for enforcement, uses the value within additional_purchased_storage_size without checking the additional_purchased_storage_ends_on field. This means even if the storage is expired we still consider the storage mentioned in the Namespacelimit as a valid storage.

This MR adds check on additional_purchased_storage_ends_on field before returning additional_purchased_storage_size. This change is behind a FF and will be rolledout based on the details mentioned in this feature-flag rollout issue

ref: https://gitlab.com/gitlab-org/gitlab/-/issues/410281

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Suraj Tripathi

Merge request reports