Skip to content

Add additional button states for stop, attach, and microphone buttons#413

Merged
nicolethoen merged 4 commits intopatternfly:mainfrom
rebeccaalpert:btnstates
Feb 3, 2025
Merged

Add additional button states for stop, attach, and microphone buttons#413
nicolethoen merged 4 commits intopatternfly:mainfrom
rebeccaalpert:btnstates

Conversation

@rebeccaalpert
Copy link
Copy Markdown
Member

@rebeccaalpert rebeccaalpert commented Jan 21, 2025 •
edited
Loading

Button State Before (Light) After (Light) Before (Dark) After (Dark)
Attach Default Screenshot 2025-01-21 at 2 06 50 PM Screenshot 2025-01-21 at 2 11 51 PM Screenshot 2025-01-21 at 2 14 57 PM Screenshot 2025-01-21 at 2 17 43 PM
Attach Hover Screenshot 2025-01-21 at 2 07 04 PM Screenshot 2025-01-21 at 2 12 09 PM Screenshot 2025-01-21 at 2 15 23 PM Screenshot 2025-01-21 at 2 17 49 PM
Attach Active Screenshot 2025-01-21 at 2 07 04 PM Screenshot 2025-01-21 at 2 12 23 PM Screenshot 2025-01-21 at 2 15 31 PM Screenshot 2025-01-21 at 2 18 01 PM
Microphone Default Screenshot 2025-01-21 at 2 07 18 PM Screenshot 2025-01-21 at 2 11 53 PM Screenshot 2025-01-21 at 2 15 00 PM Screenshot 2025-01-21 at 2 17 45 PM
Microphone Hover Screenshot 2025-01-21 at 2 07 30 PM Screenshot 2025-01-21 at 2 12 13 PM Screenshot 2025-01-21 at 2 15 23 PM Screenshot 2025-01-21 at 2 17 52 PM
Microphone Active Screenshot 2025-01-21 at 2 07 22 PM Screenshot 2025-01-21 at 2 12 16 PM Screenshot 2025-01-21 at 2 15 19 PM Screenshot 2025-01-21 at 2 17 55 PM
Stop Default Screenshot 2025-01-21 at 2 07 50 PM Screenshot 2025-01-21 at 2 12 29 PM Screenshot 2025-01-21 at 2 15 04 PM Screenshot 2025-01-21 at 2 17 31 PM
Stop Hover Screenshot 2025-01-21 at 2 07 53 PM Screenshot 2025-01-21 at 2 12 33 PM Screenshot 2025-01-21 at 2 15 07 PM Screenshot 2025-01-21 at 2 17 34 PM
Stop Active Screenshot 2025-01-21 at 2 07 57 PM Screenshot 2025-01-21 at 2 12 37 PM Screenshot 2025-01-21 at 2 15 11 PM Screenshot 2025-01-21 at 2 17 38 PM

@rebeccaalpert rebeccaalpert linked an issue Jan 21, 2025 that may be closed by this pull request
Add additional message bar button states #357
Closed
@patternfly-build
Copy link
Copy Markdown

patternfly-build commented Jan 21, 2025 •
edited
Loading

Preview: https://chatbot-pr-chatbot-413.surge.sh

A11y report: https://chatbot-pr-chatbot-413-a11y.surge.sh

kaylachumley
kaylachumley requested changes Jan 31, 2025
View reviewed changes
Copy link
Copy Markdown

@kaylachumley kaylachumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! left some comments

Comment thread packages/module/src/MessageBar/AttachButton.scss Outdated
Comment thread packages/module/src/MessageBar/AttachButton.scss
Comment thread packages/module/src/MessageBar/MicrophoneButton.scss Outdated
Comment thread packages/module/src/MessageBar/MicrophoneButton.scss Outdated
Comment thread packages/module/src/MessageBar/MicrophoneButton.scss Outdated
Comment thread packages/module/src/MessageBar/StopButton.scss Outdated
Comment thread packages/module/src/MessageBar/StopButton.scss Outdated
Comment thread packages/module/src/MessageBar/StopButton.scss Outdated
@kaylachumley
Copy link
Copy Markdown

kaylachumley commented Jan 31, 2025

one more thing! can we update the gap spacing token between the icon buttons to be pf-t--global--spacer--gap--action-to-action--plain
Screenshot 2025-01-31 at 11 14 35 AM

@rebeccaalpert
Copy link
Copy Markdown
Member Author

rebeccaalpert commented Jan 31, 2025

All set! 💃

kaylachumley
kaylachumley approved these changes Feb 3, 2025
View reviewed changes
Copy link
Copy Markdown

@kaylachumley kaylachumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@nicolethoen nicolethoen merged commit ac5ecc5 into patternfly:main Feb 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2025

🎉 This PR is included in version 2.2.0-prerelease.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolethoen nicolethoen nicolethoen approved these changes

@kaylachumley kaylachumley kaylachumley approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add additional message bar button states

4 participants

@rebeccaalpert @patternfly-build @kaylachumley @nicolethoen