fix: globs in path if cwd is not the cfg file loc#43
Merged
pawamoy merged 2 commits intomkdocstrings:masterfrom Nov 19, 2022
veghdev:glob_path_fix
Merged
fix: globs in path if cwd is not the cfg file loc#43pawamoy merged 2 commits intomkdocstrings:masterfrom veghdev:glob_path_fix
pawamoy merged 2 commits intomkdocstrings:masterfrom
veghdev:glob_path_fix
Conversation
Contributor
Author
|
I did not use the glob.glob() root_dir argument because it is only available from python 3.10. |
Contributor
Author
|
@pawamoy Could you please review? Thanks |
Member
|
Sure, I will when I get some time :) |
Member
|
CI failures unrelated, will fix in another PR. I took the liberty to modify your changes a bit, I hope you don't mind. |
Contributor
Author
No problem, I'm glad I could help and thank you for your review. |
viktorlashchuk
added a commit
to viktorlashchuk/mkdocstrings-python
that referenced
this pull request
Feb 24, 2025
Co-authored-by: Timothée Mazzucotelli <pawamoy@pm.me> Issue #42: mkdocstrings/python#42 PR #43: mkdocstrings/python#43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #42
based on the documentation: "Non-absolute paths are computed as relative to MkDocs configuration file."