build: remove @angular/common from Service Worker dependencies#59747
Closed
alan-agius4 wants to merge 2 commits intoangular:mainfrom
Closed
build: remove @angular/common from Service Worker dependencies#59747alan-agius4 wants to merge 2 commits intoangular:mainfrom
@angular/common from Service Worker dependencies#59747alan-agius4 wants to merge 2 commits intoangular:mainfrom
Conversation
The `@angular/service-worker` package no longer directly depends on `@angular/common`.
alan-agius4
added
action: review
angular-robot
bot
added
the
area: build & ci
The `@angular/service-worker` package now explicitly declares `rxjs` as a peer dependency.
alan-agius4
force-pushed
the
sw-common-angular
branch
from
af71101 to
e95d90c
Compare
devversion
approved these changes
Jan 28, 2025
alan-agius4
added
action: merge
Member
|
This PR was merged into the repository by commit e2987a1. The changes were merged into the following branches: main, 19.1.x |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jan 28, 2025
The `@angular/service-worker` package now explicitly declares `rxjs` as a peer dependency. PR Close #59747
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jan 28, 2025
) The `@angular/service-worker` package no longer directly depends on `@angular/common`. PR Close #59747
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jan 28, 2025
The `@angular/service-worker` package now explicitly declares `rxjs` as a peer dependency. PR Close #59747
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…ular#59747) The `@angular/service-worker` package no longer directly depends on `@angular/common`. PR Close angular#59747
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
The `@angular/service-worker` package now explicitly declares `rxjs` as a peer dependency. PR Close angular#59747
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@angular/service-workerpackage no longer directly depends on@angular/common.