fix: Analytics plugin - #2624
Open
creeperkatze wants to merge 1 commit into
Open
creeperkatze wants to merge 1 commit into
creeperkatze wants to merge 1 commit into
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
Contributor
Author
|
Once |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
The analytics plugin ran in every entrypoint, including MAIN-world content scripts without
browser.runtimeaccess. It imported#analyticsat the top of the file, socreateAnalytics()threw during module load and crashed the entrypoint before its own code ran. Now the import is dynamic and guarded by abrowser.runtime.idcheck, so it's skipped where there's no runtime access instead of crashing.Manual Testing
Added a MAIN-world content script next to the analytics module and confirmed it no longer crashes, while analytics still works in the background, popup, and isolated content scripts.
Related Issue
This PR closes #1847