fix: empty folder text - WPB-23213#4549
Merged
WilhelmOks merged 16 commits intodevelopfrom Apr 21, 2026
Merged
Conversation
… Added text variants for empty folders.
Contributor
Test Results347 tests 347 ✅ 2m 17s ⏱️ Results for commit df50f17. ♻️ This comment has been updated with latest results. Summary: workflow run #24731087737 |
jullianm
reviewed
Apr 13, 2026
jullianm
reviewed
Apr 15, 2026
Contributor
jullianm
left a comment
There was a problem hiding this comment.
Nice work, left a few feedbacks before approving. As we're introducing a new helper method for snapshot tests, I'd suggest adding devs from the iOS team as reviewers as well.
OlivellaO
reviewed
Apr 15, 2026
Collaborator
Author
Makes sense, I added Sam and John. |
johnxnguyen
approved these changes
Apr 21, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Issue
Added different text for empty folders (different to the text of the empty roots).
Also refactored
FilesInfoViewto make the switch logic for the different states more clear and easier to maintain.And removed
.accessibilityLabel()fromText()since it's redundant.Moved
LoadMoreViewfromFilesInfoViewinto a separate file.Second phase:
Unified
MoveToFolderEmptyStateViewintoFilesInfoView(It has been used by the Move-to-Folder view and also by the Edit-File view).Added snapshot tests for
FilesInfoView.Introduced
VariantstoSnapshotHelperto make it easier to test light/dark themes and different sizes.@johnxnguyen @caldrian please review this part in particular as it also affects the code outside of Wire Drive.
Testing