On X11, don't panic when setting WM hints for user attention fails - #29
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
request_user_attention panicked if WmHints::set could not send the request, e.g. because the X connection had died. Log a warning instead.
4 tasks
Author
|
This PR was generated with Warp. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


On X11,
Window::request_user_attentionpanicked whenWmHints::setfailed to send its request, for example after the X connection died. Warp calls this to ring the bell while its window is inactive, so a dead connection aborted the app (Sentry WARP-CLIENT-BETA-STABLE-89S1). The send error is now logged withtracing::warn!and the call returns. When the send succeeds, the cookie is still dropped withignore_error(), as before.The branch is based on
a4e0ecb5, the revision Warp pins today, so Warp can take the fix without also picking up the later commits onwarpdotdev/v0.30.x. Warp picks up this commit in warpdotdev/warp-for-benchmarks#47. Otherexpect_then_ignore_errorcall sites in the X11 backend are unchanged.cargo checkandcargo clippy --no-default-features --features x11,rwh_06are clean. No test covers the dead-connection path, because it needs a live X server that disconnects mid-call.changelogmodule: fork-only fix, no upstream changelog entry.