x11: treat WmHints::set send failure as recoverable - #24
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
…ttention When the X11 connection is dead, WmHints::set returns a ConnectionError. The previous code called expect_then_ignore_error which panics on the send error, causing an abort. User attention is best-effort — log a warning instead of crashing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WmHints::setsend failure as recoverable inrequest_user_attentionon X11, logging a warning instead of panicking.When the X11 connection is dead,
WmHints::setreturnsErr(ConnectionError). The previous code calledexpect_then_ignore_error, which panics on the send error via.expect(). Since user-attention requests are best-effort (the cookie was already being ignored on success), the send failure should also be non-fatal.Fixes Sentry WARP-CLIENT-BETA-STABLE-89S1.
Test plan
cargo check --features x11passesrequest_user_attentionis modifiedThis PR was created by Warp (running Claude Code).