x11: treat WmHints send failure as recoverable - #23
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
When the X11 connection is dead, WmHints::set() returns a ConnectionError. The previous code called expect_then_ignore_error() which panics on Err, causing Warp to abort (Sentry WARP-CLIENT-BETA-STABLE-89S1). Use if-let instead: silently drop a send failure, and on success keep ignoring the cookie the same way. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a dead X11 connection,
WmHints::set()returnsErr(ConnectionError). The current code callsexpect_then_ignore_error(), which panics on theErrvariant, causing Warp to abort (Sentry WARP-CLIENT-BETA-STABLE-89S1). This makes the send failure recoverable: silently drop it, and on success keep ignoring the cookie the same way.What changed
request_user_attentioninsrc/platform_impl/linux/x11/window.rsnow usesif let Ok(cookie)instead ofexpect_then_ignore_error, matching the get-side's existing graceful error handling.Validation
cargo check --lib -p winit --features x11passes cleanly.changelogmodule if knowledge of this change could be valuable to usersThis PR was created by Warp (running Claude Code).