Bound Global Search submatch expansion (APP-5251) - #16079
Open
warp-agent-staging[bot] wants to merge 2 commits into
Open
warp-agent-staging[bot] wants to merge 2 commits into
warp-agent-staging[bot] wants to merge 2 commits into
Conversation
Contributor
Author
|
This PR was generated with Warp. Comment |
Contributor
Author
|
ticket_id: APP-5251 · ticket_source: linear This PR is now stacked directly on #15785, so its diff contains only the bounded submatch expansion, shared stored-window ownership, and model-budget changes. #15785 remains the base dependency. Responding as wilson: Open session · View in factory |
warp-agent-staging
Bot
force-pushed
the
factory/app-5251-bounded-submatches
branch
from
September 18, 2026 13:59
0e95536 to
8d47e41
Compare
warp-agent-staging
Bot
changed the base branch from
master
to
factory/app-5785-global-search-line-text-cap
September 18, 2026 14:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Global Search now expands at most 100 submatches from one matched line and shares each final owned 4-KiB stored text window across retained rows. A shared 20,000-row model budget spans local and remote sources, while remote results expand and flush incrementally instead of building a large intermediate vector.
Per-line and total-budget truncation now reach the existing partial-results warning and telemetry. Column calculation, leading-whitespace trimming, stored-window offset remapping, and highlighting remain accurate.
Evidence: APP-5251.
Linked Issue
ready-to-specorready-to-implement. APP-5251 is tracked in Linear and is In Progress.Testing
cargo nextest run --manifest-path Cargo.toml -p warp -E 'test(/global_search/)'— 23 passed.cargo clippy --manifest-path Cargo.toml -p warp --all-targets --tests -- -D warnings— passed../script/format— completed../script/presubmit— formatting and configured Clippy stages passed; the workspace test build could not complete because the 63-GB sandbox filesystem filled while writing rustc's query cache.I have manually tested my changes locally with
./script/run. The deterministic model behavior is covered by focused unit tests.Agent Mode
CHANGELOG-BUG-FIX: Prevented excessive Global Search memory use when a pattern has many matches on one line.