Fix desktop web IME input through a DOM text bridge - #16078
lorenzozanee wants to merge 1 commit into
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @lorenzozanee on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
Every PR must be linked to a same-repo issue before Oz can review it. Next step: open or find a same-repo issue describing this change, then link it to this PR by adding See the contribution guidelines for the full readiness model. Powered by Oz |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /warp-agent-review to re-trigger review.
See the contribution guidelines for the full readiness model.
Powered by Oz
|
Hi @lorenzozanee — a reviewer requested changes on this PR and it hasn't had activity from you in 7 days. When you get a chance, please push updates or reply to the review so a reviewer can take another look. Without activity, this PR will be automatically closed after 14 days of inactivity. |
Description
Add a desktop WASM text-input bridge for browser IME composition, preserve marked-text lifecycle, suppress duplicate commit input, and avoid focusing read-only terminals. This addresses the browser input-rejection half of the issue; CJK scrollback rendering remains outside the verified scope.
Linked Issue
Issue #16060
ready-to-specorready-to-implement; the issue currently has neither label.Testing
cargo test -p warpui desktop_text_input_reducer --lib(22 passed)cargo test -p warpui focus_handoff --lib(5 passed)./script/format --checkcargo clippy -p warpui --all-targets --tests -- -D warningsgit diff --check./script/run; Chrome/macOS IME and CJK rendering checks remain pending.Screenshots / Videos
Not available; browser and macOS IME validation remains pending.
Agent Mode
CHANGELOG-NONE