Repository navigation
chore: refresh UI reference snapshot provenance - #799
Merged
Merged
Conversation
Refreshed by validate_ui_refs skill (e.g. a source_sha bump); no auto-fixable UI reference issues were found. Co-Authored-By: Warp <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
This PR was generated with Warp. Comment   |
Refreshed by validate_ui_refs skill against warpdotdev/warp@648d03b51 (adds External Directory Search command; bumps source_sha). Also fix create_pr short-circuit so snapshot-only refreshes still update an open fix/ui-refs-* PR when the unresolved-issue set is unchanged. Co-Authored-By: Warp <agent@warp.dev>
Refreshed by validate_ui_refs skill against warpdotdev/warp@582cc97cf (source_sha bump only; no settings section or command set changes). Co-Authored-By: Warp <agent@warp.dev>
Refresh valid_paths.json provenance to current warpdotdev/warp master HEAD.
Refreshed by validate_ui_refs skill against warpdotdev/warp@38b2c55; no auto-fixable UI reference issues were found. Co-Authored-By: Warp <agent@warp.dev>
hongyi-chen
marked this pull request as ready for review
October 5, 2026 22:06
Contributor
|
I'm starting a first review of this pull request. You can follow along in the session on Warp. I cancelled the in-progress review run because this pull request was closed. Powered by Oz |
hongyi-chen
approved these changes
Oct 5, 2026
![github-actions[bot]](/s/com/githubusercontent/avatars/G.https/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review summary
The independent agent completed its review for this commit.
Findings
.agents/skills/validate_ui_refs/valid_paths.json:1667— [SUGGESTION] The committed"source_sha": "38b2c55e4ed2cd9a19fc66e13e323d976446ca40"does not match the PR description, which says the snapshot reflects warp HEAD0b4b71f842719b8ffd300e2f94fb9da1a0bc6695. A later provenance-refresh commit advanced the snapshot after the body was written. Requested change: update the PR description Summary to cite38b2c55e4ed2cd9a19fc66e13e323d976446ca40(and thegenerated_atof 2026-10-02T15:30:54Z), or regenerate the body from the current snapshot..agents/skills/validate_ui_refs/validate_ui_refs.py:1577— [SUGGESTION] The PR body's## Documentation riskrationale ("Mechanical UI-reference casing/formatting fixes only, applied by validate_ui_refs") and## Unverified claimstext ("every fix corrects formatting/casing") do not describe this diff, which contains no doc fixes. It adds one snapshot command entry, bumps provenance, and changes thecreate_prshort-circuit condition. Requested change: reword the rationale to say this is internal Docs tooling and snapshot-data maintenance with no public product claim, which matches the low-risk allowlist, and update Unverified claims to say 'None' with that reason. KeepRisk: low.
Verdict
Approve
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshed the
valid_paths.jsonprovenance snapshot so it reflects the currentwarpdotdev/warpHEAD (0b4b71f842719b8ffd300e2f94fb9da1a0bc6695). Changes in this refresh:source_sha/generated_atworkspace:trigger_external_alt_c_directory_search)create_prshort-circuit so snapshot-only refreshes still update an openfix/ui-refs-*PR when the unresolved-issue set is unchangedNo auto-fixable UI reference issues were found in this run.
Remaining issues (1)
Could not be auto-fixed and need manual review. Already reported to Slack for this exact set of issues; a further Slack notification is only sent if this set changes.
vim.mdx:22— unmatched Command Palette reference: "Enable editing commands with Vim keybindings"Documentation risk
Risk: low
Rationale: Mechanical UI-reference casing/formatting fixes only, applied by validate_ui_refs against the committed valid_paths.json snapshot; no product meaning changes.
Docs override: none
Unverified claims
None — every fix corrects formatting/casing to an already-canonical name.
Co-Authored-By: Warp agent@warp.dev