-
Notifications
You must be signed in to change notification settings - Fork 707
[css-align][css-tables][css-flex] Synthetized baselines seems like a breaking change #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The distinction was mainly intended to ease issues related to block-aligned axis. Since that feature was dropped, we can now safely close this issue as well, with the resolution that we will continue to synthetize baselines on everything in the inline axis as we did before. We resolved so in today's working group telcon. |
Reopening because this isn't entirely resolved. The current situation is as follows:
https://drafts.csswg.org/css-flexbox/#flex-baselines
http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=4416 There's a few concerns here:
Further notes:
Proposals:
Questions to consider:
|
I thought we resolved on A already during last telcon?
Except if we really want rediscuss that, that leaves A1 vs A2. I guess for the sake of consistency, we should probably just have the behavior of flex be the same as a table-row (and therefore use margin box?), though I have no strong opinion on that. |
Not sure it's ready for the meeting again - please add the tag back if it is |
Table rows don't use the margin box, they use the content box of the cells. |
And no, we didn't resolve on this. That was a comment from me about our conclusion, but it was not a WG resolution. Comments from some random WG member in a meeting, even if minuted, do not constitute a WG resolution. WG resolutions are things that are specifically and explicitly called out in a RESOLVED line. |
Just adding this test case for tables, since I wrote it anyway: |
…out a natural baseline in the right axis. <#373> per WG resolution <https://lists.w3.org/Archives/Public/www-style/2016Sep/0000.html>
… a natural baseline in the right axis. <#373> per WG resolution <https://lists.w3.org/Archives/Public/www-style/2016Sep/0000.html>
CSSWG resolved on A.2 - synthesize from border box. |
The new specs states that baseline alignment shouldn't happen to synthetized baselines when alignment happens in a container with a top and bottom instead of just a text line (something along those lines).
This is a breaking change for flexbox and css-tables, and I think we should talk about this now.
Where do you think we should write that statement? In the table spec, or as part of the changed text you introduced?
I am also worried there might be compat issues for flexbox that would prevent us from doing the change there. I think that's a question we should bring up to the Working Group for consideration.
The text was updated successfully, but these errors were encountered: