vdk-trino: collect lineage for select/insert and rename table only#756
Merged
philip-alexiev merged 9 commits intomainfrom Mar 15, 2022
Merged
vdk-trino: collect lineage for select/insert and rename table only#756philip-alexiev merged 9 commits intomainfrom
philip-alexiev merged 9 commits intomainfrom
Conversation
Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com)
antoniivanov
suggested changes
Mar 8, 2022
projects/vdk-plugins/vdk-trino/src/vdk/plugin/trino/trino_connection.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-trino/src/vdk/plugin/trino/trino_connection.py
Outdated
Show resolved
Hide resolved
Contributor
|
I am not sure if you noticed - the CI tests failed (ci/gitlab/gitlab.com -> Click Details) - https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/2176218096 |
Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com)
Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com)
antoniivanov
approved these changes
Mar 10, 2022
Contributor
antoniivanov
left a comment
antoniivanov
left a comment
There was a problem hiding this comment.
Looks good to me. You can add a few more tests about some corner cases.
Author
|
@tozka Thank you for the review and valuable comments. |
added 4 commits
March 11, 2022 17:03
Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com)
Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com)
Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com)
antoniivanov
approved these changes
Mar 15, 2022
added 2 commits
March 15, 2022 10:51
Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com)
Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com)
ivakoleva
pushed a commit
that referenced
this pull request
Mar 22, 2022
) * vdk-trino: collect lineage for select/insert and rename table only Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com) * vdk-trino: collect lineage for select/insert and rename table only Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com) * vdk-trino: collect lineage for select/insert and rename table only Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com) * vdk-trino: collect lineage for select/insert and rename table only Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com) * vdk-trino: collect lineage for select/insert and rename table only Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com) * vdk-trino: collect lineage for select/insert and rename table only Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com) * vdk-trino: collect lineage for select/insert and rename table only Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com) * vdk-trino: collect lineage for select/insert and rename table only Why: To make lineage collecting more production ready, some improvements are needed. What: In order to reduce the load on the query engine, only plans for insert/select queries are calculated. For rename table queries, the plan doesn't give information. The query is parsed and table names extracted. Counting the number of rows in the output table before and after is removed to reduce the burden on the query engine. How has this been tested: Tweaked the test_vdk_trino_lineage.py test to be more comprehensive and cover all scenarios. What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Philip Alexiev (palexiev@vmware.com)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
To make lineage collecting more production ready,
some improvements are needed.
What:
In order to reduce the load on the query engine,
only plans for insert/select queries are calculated.
For rename table queries, the plan doesn't give information.
The query is parsed and table names extracted.
Counting the number of rows in the output table before and after
is removed to reduce the burden on the query engine.
How has this been tested:
Tweaked the test_vdk_trino_lineage.py test
to be more comprehensive and cover all scenarios.
What type of change are you making?
Bug fix (non-breaking change which fixes an issue)
or a cosmetic change/minor improvement
Signed-off-by: Philip Alexiev (palexiev@vmware.com)