vdk-server: url in swagger ui is correct #2380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
for more information, see https://pre-commit.ci
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
murphp15
force-pushed
the
person/murphp15/support_url_configuration
branch
from
97cdd4f to
cc90600
Compare
for more information, see https://pre-commit.ci
murphp15
changed the title
Signed-off-by: murphp15 <murphp15@tcd.ie>
...pipelines_control_service/src/main/java/com/vmware/taurus/datajobs/SwaggerConfiguration.java
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-server/src/vdk/plugin/server/installer.py
Outdated
Show resolved
Hide resolved
DeltaMichael
approved these changes
Jul 11, 2023
antoniivanov
suggested changes
Jul 11, 2023
...pipelines_control_service/src/main/java/com/vmware/taurus/datajobs/SwaggerConfiguration.java
Outdated
Show resolved
Hide resolved
...pipelines_control_service/src/main/java/com/vmware/taurus/datajobs/SwaggerConfiguration.java
Show resolved
Hide resolved
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
antoniivanov
approved these changes
Jul 11, 2023
Contributor
antoniivanov
left a comment
antoniivanov
left a comment
There was a problem hiding this comment.
Thanks! Looks good. I left general recommenation comment which you can ignore for this change if you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When using quickstart VDK the swagger endpoint thinks that the base url should be http://localhost when infact it should be http://localhost:8092.
The reason it gets confused is because we map the kind cluster port 80 to 8092 on the local machine.
What
The only fix available to us is to hard code the url in the quickstart vdk installer class.
How was this tested
In a previous commit I release and image and tested quickstart vdk locally with the change