control-service: use real class when testing instead of mock #2261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
duyguHsnHsn
approved these changes
Jun 15, 2023
Signed-off-by: murphp15 <murphp15@tcd.ie>
antoniivanov
approved these changes
Jun 15, 2023
Signed-off-by: murphp15 <murphp15@tcd.ie>
murphp15
deleted the
person/murphp15/use_real_class_when_testing_instead_of_mock
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We were creating a mock just to tell it to call the real methods.
This is pointless.
What
Use a real instance instead.
It results in less code.
We are testing the product closer to how it will actually be used and it is easier for debugging.
How was this tested
Locally