vdk-core: Update JobConfig to match vdk-control-cli JobConfig #2226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is code duplication between the vdk-core's JobConfig and vdk-control-cli's JobConfig. This is not sustainable, as when a change in one component is made, this change would need to be ported to the other component. This change updates the vdk-core's JobConfig, as vdk-core is the main component of the Versatile Data Kit SDK. In a separate PR, the JobConfig of vdk-control-cli will be removed to remove the code duplication. Testing Done: CI/CD Signed-off-by: Andon Andonov <andonova@vmware.com>
dakodakov
approved these changes
Jun 9, 2023
gabrielgeorgiev1
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is code duplication between the vdk-core's JobConfig and vdk-control-cli's JobConfig. This is not sustainable, as when a change in one component is made, this change would need to be ported to the other component.
This change updates the vdk-core's JobConfig, as vdk-core is the main component of the Versatile Data Kit SDK. In a separate PR, the JobConfig of vdk-control-cli will be removed to remove the code duplication.
Testing Done: CI/CD