control-service: Rework supported python version logic #1992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
force-pushed
the
person/andonova/rework-job-deploy
branch
from
699fa99 to
f15aa5d
Compare
Currently, there are two groups of configurations to set the vdk and job base images used in data job deployments. The old way, through the `datajobs.deployment.dataJobBaseImage` and `datajobs.vdk.image`, and the new way, through the support for multiple python versions in data job deployments. The two groups of configurations are in conflict, as the old configuration options take precedence and cleanly migrating to the support for multiple python versions is practically impossible. This change removes the default values for the `datajobs.deployment.supportedPythonVersions` and `datajobs.deployment.defaultPythonVersion` properties, and udates the service logic so that when these properties are set in an environment, they take precedence over the old configuration. Testing Done: CI/CD Signed-off-by: Andon Andonov <andonova@vmware.com>
Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/rework-job-deploy
branch
from
2f918cb to
d33fe8a
Compare
dakodakov
approved these changes
May 2, 2023
mivanov1988
approved these changes
May 2, 2023
doks5
added a commit
that referenced
this pull request
May 2, 2023
Reverts #1992 --------- Co-authored-by: github-actions <>
yonitoo
pushed a commit
that referenced
this pull request
May 3, 2023
Currently, there are two groups of configurations to set the vdk and job base images used in data job deployments. The old way, through the `datajobs.deployment.dataJobBaseImage` and `datajobs.vdk.image`, and the new way, through the support for multiple python versions in data job deployments. The two groups of configurations are in conflict, as the old configuration options take precedence and cleanly migrating to the support for multiple python versions is practically impossible. This change removes the default values for the `datajobs.deployment.supportedPythonVersions` and `datajobs.deployment.defaultPythonVersion` properties, and updates the service logic so that when these properties are set in an environment, they take precedence over the old configuration. Testing Done: CI/CD --------- Signed-off-by: Andon Andonov <andonova@vmware.com> Co-authored-by: github-actions <>
yonitoo
pushed a commit
that referenced
this pull request
May 3, 2023
Reverts #1992 --------- Co-authored-by: github-actions <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are two groups of configurations to set the vdk and job base images used in data job deployments. The old way, through the
datajobs.deployment.dataJobBaseImageanddatajobs.vdk.image, and the new way, through the support for multiple python versions in data job deployments.The two groups of configurations are in conflict, as the old configuration options take precedence and cleanly migrating to the support for multiple python versions is practically impossible.
This change removes the default values for the
datajobs.deployment.supportedPythonVersionsanddatajobs.deployment.defaultPythonVersionproperties, and updates the service logic so that when these properties are set in an environment, they take precedence over the old configuration.Testing Done: CI/CD