Skip to content

Conversation

@murphp15
Copy link
Contributor

@murphp15 murphp15 commented Apr 24, 2023

Why

We are failing to build the python api client in the main branch.
There are two issues.
The first is that we are trying to install python using apk.
This is not needed and is causing errors.

Also we are running out of memory generating the api client.
Upgrading to the latest version of the dependency has fixed this.
I was also able to delete .mustache files that we needed in our repo as a workaround to issues from using an older version of openapi-generator.

How has this been tested.

Tested manually by making a commit where the client is built for any change.
Also integration tests

ddakov and others added 7 commits April 20, 2023 16:09
Publish a new version of the python client library - 1.0.7 -
to expose supported python versions api

Signed-off-by: Dako Dakov <ddakov@vmware.com>
Dummy to re-trigger pipeline

Signed-off-by: Dako Dakov <ddakov@vmware.com>
The integration tests are run from commits on many irrelevant files.
This is first step in removing some of those irrelenat triggers.

Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
@murphp15 murphp15 marked this pull request as draft April 24, 2023 10:37
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
@murphp15 murphp15 changed the title Person/murphp15/fix api release Control-service: ix python api release Apr 24, 2023
@murphp15 murphp15 changed the title Control-service: ix python api release Control-service: fix python api release Apr 24, 2023
@murphp15 murphp15 requested review from dakodakov and ivakoleva April 24, 2023 11:19
Signed-off-by: murphp15 <murphp15@tcd.ie>
@murphp15 murphp15 marked this pull request as ready for review April 24, 2023 12:34
Copy link
Contributor

@ivakoleva ivakoleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking into this.

Signed-off-by: murphp15 <murphp15@tcd.ie>
@murphp15 murphp15 enabled auto-merge (squash) April 24, 2023 13:14
@murphp15 murphp15 merged commit da146f4 into main Apr 24, 2023
@murphp15 murphp15 deleted the person/murphp15/fix_api_release branch April 24, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants