control-service: fix failing image publisher #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
ivakoleva
approved these changes
Mar 31, 2023
Contributor
ivakoleva
left a comment
ivakoleva
left a comment
There was a problem hiding this comment.
interesting, I thought I did a code review recently, and explicitly checked all occurrences of docker and dind. Anyway....this must be optimised for extension over duplication.
Contributor
|
may provide PR description? |
murphp15
changed the title
Contributor
Author
|
@ivakoleva description added, draft removed. |
yonitoo
pushed a commit
that referenced
this pull request
Apr 4, 2023
# Why Builds were failing because of the docker image we were using. # What I upgraded to the latest one. This is one we are using in more places in the the gitlab pipeline. # How has this been tested. In a previous commit I enabled those jobs on this PR and made sure they ran successfully. --------- Signed-off-by: murphp15 <murphp15@tcd.ie> Co-authored-by: Momchil Z <mzhivkov@vmware.com>
mrMoZ1
pushed a commit
that referenced
this pull request
Apr 4, 2023
what: reverted to previously used python version for the job builder container and bumped version.txt to trigger new release. why: as a part of this PR #1810 job builder version was bumped, however this introduces problems with the awscli library used in the builder - it now fails with a missing module. : `... File "/usr/lib/python3.10/site-packages/dateutil/tz/tz.py", line 19, in <module> import six ModuleNotFoundError: No module named 'six'` Reverting to python 3.7 seems to fix the issue. testing: created image locally and tested that aws commands in container work as expected. --------- Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Builds were failing because of the docker image we were using.
What
I upgraded to the latest one. This is one we are using in more places in the the gitlab pipeline.
How has this been tested.
In a previous commit I enabled those jobs on this PR and made sure they ran successfully.