Repository navigation
Conversation
Restore the module's unset model-input sentinel when copying or unpickling it. Tool messages then compare equal to their pickle, deep copy and deep model copy without changing their serialized fields.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
msullivan
approved these changes
Nov 18, 2026
Comment on lines
+205
to
+206
| def __reduce__(self) -> str: | ||
| return "MODEL_INPUT_UNSET" |
Collaborator
There was a problem hiding this comment.
Hm I don't understand this.
We should consider using the new sentinel feature though
msullivan
reviewed
Nov 18, 2026
| return "MODEL_INPUT_UNSET" | ||
|
|
||
|
|
||
| MODEL_INPUT_UNSET: Any = _ModelInputUnset() |
Collaborator
There was a problem hiding this comment.
Aha: "If a string is returned, the string should be interpreted as the name of a global variable.", from __reduce__ docs...
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool messages with no
model_inputdidn't compare equal to their deep copies or after a pickle round trip. Copying or unpickling made a new unset marker; now we keep the same one. The dumped data and JSON haven't changed.