Added a constructor with custom OkHttpClient#86
Merged
kishorenc merged 1 commit intotypesense:masterfrom Sep 14, 2025
Merged
Conversation
|
Hello @haydenhoang. Sorry for pinging. Is this something the team is interested in merging? Would be extreme useful. Thanks ❤️ |
Contributor
|
@kishorenc could you merge this? |
kishorenc
approved these changes
Sep 14, 2025
Member
|
I just noticed that after merging this PR, the CI is failing for Java 8. Can you please check: https://github.com/typesense/typesense-java/actions/runs/17708818128/job/50324642117 |
Contributor
|
This is caused by v30 breaking change in the Typesense api spec. The spec file is pulled and codegen is performed at build time, which is why the CI failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
To customize certain aspects of the HTTP calls being made, we need to access and control the HTTP client being used. This PR adds another constructor for the client to accept, in addition to the configuration, an
OkHttpClient, which is simply passed to theAPIClientthat already accepts such a parameter.PR Checklist