Skip to content

fix: fix synonym delete response schema#80

Merged
kishorenc merged 1 commit intotypesense:masterfrom
tharropoulos:synonym-delete-response
Nov 8, 2024
Merged

fix: fix synonym delete response schema#80
kishorenc merged 1 commit intotypesense:masterfrom
tharropoulos:synonym-delete-response

Conversation

@tharropoulos
Copy link
Contributor

Change Summary

The current API spec defines the return schema of a successful DELETE request on the /collection/{collectionName}/synonyms/{synonymId} endpoint as SearchSynonym, matching the ones from either GET, POST, or PUT requests. Actually calling the API presents a JSON object with only the id field being defined:

❯ curl "http://localhost:8108/collections/products/synonyms/coat-synonyms" -X DELETE \
-H "Content-Type: application/json" \
-H "X-TYPESENSE-API-KEY: ${TYPESENSE_API_KEY}"

{"id":"coat-synonyms"}

Changes

  • fix response schema for DELETE /collection/{collectionName}/synonyms/{synonymId} endpoint
  • add missing SearchSynonymDeleteReponse schema definition

PR Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants